Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks - Revise step time collection in distributed inference benchmark #524

Merged
merged 2 commits into from Apr 24, 2023

Conversation

yzygitzh
Copy link
Member

Description
This commit revises distributed inference benchmark to give a unified step time result by taking maximum step times of different GPUs.

@yzygitzh yzygitzh requested a review from a team as a code owner April 18, 2023 07:30
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #524 (8e138f4) into main (51761b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          89       89           
  Lines        5964     5965    +1     
=======================================
+ Hits         5203     5204    +1     
  Misses        761      761           
Flag Coverage Δ
cpu-python3.6-unit-test 73.48% <50.00%> (+<0.01%) ⬆️
cpu-python3.7-unit-test 73.48% <50.00%> (+<0.01%) ⬆️
cpu-python3.8-unit-test 73.95% <50.00%> (+<0.01%) ⬆️
cuda-unit-test 87.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ench/benchmarks/micro_benchmarks/dist_inference.py 81.14% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cp5555 cp5555 mentioned this pull request Apr 23, 2023
21 tasks
@yzygitzh yzygitzh merged commit 4cb431c into microsoft:main Apr 24, 2023
22 checks passed
@yzygitzh yzygitzh deleted the ziyyang/fix-dist-inf-time branch April 24, 2023 02:18
@cp5555 cp5555 added bug Something isn't working micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks labels Jun 28, 2023
@yukirora yukirora mentioned this pull request Jul 12, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants