Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks - Revise step time collection in distributed inference benchmark #524

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Benchmarks - Revise step time collection in distributed inference benchmark #524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79352f
fix result generation
yzygitzh Apr 18, 2023
8e138f4
fix import
yzygitzh Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion superbench/benchmarks/micro_benchmarks/dist_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from superbench.benchmarks import DistributedImpl, DistributedBackend, BenchmarkRegistry, ReturnCode, Precision
from superbench.benchmarks.micro_benchmarks import MicroBenchmark
from superbench.benchmarks.context import Enum
from superbench.benchmarks.reducer import ReduceType


class ComputationKernelType(Enum):
Expand Down Expand Up @@ -390,7 +391,7 @@ def _process_data(self, step_times):
Return:
True if _process_data succeeds.
"""
if not self._process_numeric_result('step_times', step_times, cal_percentile=True):
if not self._process_numeric_result('step_times', step_times, reduce_type=ReduceType.MAX, cal_percentile=True):
abuccts marked this conversation as resolved.
Show resolved Hide resolved
return False
return True

Expand Down