Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: Bug Fix - Make metrics of dist-inference-cpp aligned with PyTorch version #596

Merged
merged 10 commits into from
Dec 16, 2023

Conversation

yzygitzh
Copy link
Member

Description
Make metrics of dist-inference-cpp aligned with PyTorch version.

@yzygitzh yzygitzh requested a review from a team as a code owner December 14, 2023 13:49
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c039b5) 86.13% compared to head (e5f176d) 86.12%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.10     #596      +/-   ##
================================================
- Coverage         86.13%   86.12%   -0.01%     
================================================
  Files                97       97              
  Lines              6879     6878       -1     
================================================
- Hits               5925     5924       -1     
  Misses              954      954              
Flag Coverage Δ
cpu-python3.6-unit-test 71.85% <0.00%> (+0.01%) ⬆️
cpu-python3.7-unit-test 71.85% <0.00%> (+0.01%) ⬆️
cpu-python3.8-unit-test 72.26% <0.00%> (+0.01%) ⬆️
cuda-unit-test 84.15% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cp5555 cp5555 changed the title Benchmarks: Microbenchmark - Make metrics of dist-inference-cpp aligned with PyTorch version Benchmarks: Bug Fix - Make metrics of dist-inference-cpp aligned with PyTorch version Dec 14, 2023
@cp5555 cp5555 added benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks labels Dec 14, 2023
@cp5555 cp5555 added the bug Something isn't working label Dec 14, 2023
@cp5555 cp5555 mentioned this pull request Dec 14, 2023
30 tasks
@yzygitzh yzygitzh merged commit b0cc8e1 into microsoft:release/0.10 Dec 16, 2023
20 checks passed
abuccts pushed a commit that referenced this pull request Jan 3, 2024
… PyTorch version (#596)

**Description**
Make metrics of dist-inference-cpp aligned with PyTorch version.

---------

Co-authored-by: Yuting Jiang <yutingjiang@microsoft.com>
abuccts added a commit that referenced this pull request Jan 8, 2024
**Description**

Cherry-pick bug fixes from v0.10.0 to main.

**Major Revisions**

* Benchmarks: Microbenchmark - Support different hipblasLt data types in dist_inference #590
* Benchmarks: Microbenchmark - Support in-place for NCCL/RCCL benchmark #591
* Bug Fix - Fix NUMA Domains Swap Issue in NDv4 Topology File #592
* Benchmarks: Microbenchmark - Add data type option for NCCL and RCCL tests #595
* Benchmarks: Bug Fix - Make metrics of dist-inference-cpp aligned with PyTorch version #596
* CI/CD - Add ndv5 topo file #597
* Benchmarks: Microbenchmark - Improve AMD GPU P2P performance with fine-grained GPU memory #593
* Benchmarks: Build Pipeline - fix nccl and nccl test version to 2.18.3 to resolve hang issue in cuda12.2 docker #599
* Dockerfile - Bug fix for rocm docker build and deploy #598
* Benchmarks: Microbenchmark - Adapt to hipblasLt data type changes #603
* Benchmarks: Micro benchmarks - Update hipblaslt metric unit to tflops #604
* Monitor - Upgrade pyrsmi to amdsmi python library. #601
* Benchmarks: Micro benchmarks - add fp8 and initialization for hipblaslt benchmark #605
* Dockerfile - Add rocm6.0 dockerfile #602
* Bug Fix - Bug fix for latest megatron-lm benchmark #600
* Docs - Upgrade version and release note #606

Co-authored-by: Ziyue Yang <ziyyang@microsoft.com>
Co-authored-by: Yang Wang <yangwang1@microsoft.com>
Co-authored-by: Yuting Jiang <yutingjiang@microsoft.com>
Co-authored-by: guoshzhao <guzhao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks SuperBench Benchmarks bug Something isn't working micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants