Skip to content

Commit

Permalink
Revert "Override center on launch setting when position specified on …
Browse files Browse the repository at this point in the history 
…cmdline (#14229)"

**REJECTED**: --pos and --size are not present in 1.15.

This reverts commit 58ddc9a.
  • Loading branch information
@DHowett
DHowett committed Dec 13, 2022
1 parent 7b93943 commit 2c81220
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/cascadia/TerminalApp/AppLogic.cpp
View file
Expand Up @@ -744,8 +744,7 @@ namespace winrt::TerminalApp::implementation
// Load settings if we haven't already
LoadSettings();
}
// If the position has been specified on the commandline, don't center on launch
return _settings.GlobalSettings().CenterOnLaunch() && !_appArgs.GetPosition().has_value();
return _settings.GlobalSettings().CenterOnLaunch();
}

winrt::Windows::UI::Xaml::ElementTheme AppLogic::GetRequestedTheme()
Expand Down

1 comment on commit 2c81220

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log for details.

Unrecognized words (17) 
AOn
apimswincoresynchl
AStomps
BGRA
Childitem
cppm
finsh
fmix
FNV
halfwidth
icch
intrin
iwch
ixx
ppci
QWERTYUIOP
WSpace
Previously acknowledged words that are now absent aabbcc abbcc ABCDEFGHIJKLMNOPQRSTUVWXY bgra COLORMATRIX DECARM DECBKM DECCARA DECERA DECFRA DECRARA DECSACE DECSERA DECXCPR dxguid ect eplace GETKEYSTATE hicon hrottled icket IWIC luma MAPVIRTUALKEY nto otepad Qaabbcc Qxxxxxxxxxxxxxxx Tdd umul umulh VKKEYSCAN wic wincodec wyhash wymix wyr xwwyzz xxyyzz Zabcdefghijklmnopqrstuvwxyz ZYXWVU ZYXWVUTd :arrow_right:
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:microsoft/terminal.git repository
on the release-1.15 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/terminal/actions/runs/3681659750/attempts/1'
Errors (1)

See the 📜action log for details.

❌ Errors Count
❌ forbidden-pattern 16

See ❌ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. If it doesn't work for you, you can manually add (one word per line) / remove items to expect.txt and the excludes.txt files.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.