Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override center on launch setting when position specified on cmdline #14229

Merged
1 commit merged into from Oct 17, 2022

Conversation

ianjoneill
Copy link
Contributor

@ianjoneill ianjoneill commented Oct 15, 2022

Override the center on launch setting when a position is specified on the commandline.

Validation Steps Performed

  1. Set center on launch in the SUI.
  2. Run wtd - the new window is centered.
  3. Run wtd --pos 100,200 - the new window is positioned at (100,200).

Closes #14176

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Oct 15, 2022
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding, and thanks for the quick fix!

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghost ghost merged commit 42befa7 into microsoft:main Oct 17, 2022
@DHowett DHowett added this to To Cherry Pick in 1.15 Servicing Pipeline via automation Dec 12, 2022
@DHowett DHowett added this to To Cherry Pick in 1.16 Servicing Pipeline via automation Dec 12, 2022
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.15 Servicing Pipeline Dec 12, 2022
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.16 Servicing Pipeline Dec 12, 2022
DHowett pushed a commit that referenced this pull request Dec 12, 2022
…14229)

Override the center on launch setting when a position is specified on the commandline.

## Validation Steps Performed
1. Set center on launch in the SUI.
2. Run `wtd` - the new window is centered.
3. Run `wtd --pos 100,200` - the new window is positioned at (100,200).

Closes #14176

(cherry picked from commit 42befa7)
Service-Card-Id: 87207151
Service-Version: 1.16
DHowett pushed a commit that referenced this pull request Dec 12, 2022
…14229)

Override the center on launch setting when a position is specified on the commandline.

## Validation Steps Performed
1. Set center on launch in the SUI.
2. Run `wtd` - the new window is centered.
3. Run `wtd --pos 100,200` - the new window is positioned at (100,200).

Closes #14176

(cherry picked from commit 42befa7)
Service-Card-Id: 87207150
Service-Version: 1.15
@DHowett DHowett moved this from Cherry Picked to Rejected in 1.16 Servicing Pipeline Dec 12, 2022
DHowett added a commit that referenced this pull request Dec 12, 2022
DHowett added a commit that referenced this pull request Dec 13, 2022
…cmdline (#14229)"

**REJECTED**: --pos and --size are not present in 1.15.

This reverts commit 58ddc9a.
@DHowett DHowett moved this from Cherry Picked to Rejected in 1.15 Servicing Pipeline Dec 13, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Using coordinates terminal window not positioned as intended by user
3 participants