revert 1449088, d3b5533 and 0bda66f, because we didn't know what they…

… did. Maybe relevant to #12861
microsoft · Aug 8, 2023 · 8f0b6f8 · 8f0b6f8
1 parent 902ee8e
commit 8f0b6f8
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/src/cascadia/TerminalApp/CommandPalette.cpp b/src/cascadia/TerminalApp/CommandPalette.cpp
@@ -225,24 +225,15 @@ namespace winrt::TerminalApp::implementation
     void CommandPalette::_selectedCommandChanged(const IInspectable& /*sender*/,
                                                  const Windows::UI::Xaml::RoutedEventArgs& /*args*/)
     {
-        const auto currentlyVisible{ Visibility() == Visibility::Visible };
-
         const auto selectedCommand = _filteredActionsView().SelectedItem();
         const auto filteredCommand{ selectedCommand.try_as<winrt::TerminalApp::FilteredCommand>() };
         if (_currentMode == CommandPaletteMode::TabSwitchMode)
         {
             _switchToTab(filteredCommand);
         }
-        else if (_currentMode == CommandPaletteMode::ActionMode &&
-                 currentlyVisible)
+        else if (_currentMode == CommandPaletteMode::ActionMode && filteredCommand != nullptr)
         {
-            // If we don't have a selected command, then end any previews we
-            // might currently be showing.
-            if (filteredCommand == nullptr)
-            {
-                _PreviewActionHandlers(*this, nullptr);
-            }
-            else if (const auto actionPaletteItem{ filteredCommand.Item().try_as<winrt::TerminalApp::ActionPaletteItem>() })
+            if (const auto actionPaletteItem{ filteredCommand.Item().try_as<winrt::TerminalApp::ActionPaletteItem>() })
             {
                 _PreviewActionHandlers(*this, actionPaletteItem.Command());
             }
@@ -1092,9 +1083,7 @@ namespace winrt::TerminalApp::implementation
         {
             std::copy(begin(commandsToFilter), end(commandsToFilter), std::back_inserter(actions));
         }
-        else if (_currentMode == CommandPaletteMode::TabSearchMode ||
-                 _currentMode == CommandPaletteMode::ActionMode ||
-                 _currentMode == CommandPaletteMode::CommandlineMode)
+        else if (_currentMode == CommandPaletteMode::TabSearchMode || _currentMode == CommandPaletteMode::ActionMode || _currentMode == CommandPaletteMode::CommandlineMode)
         {
             for (const auto& action : commandsToFilter)
             {