Remove the animations from the command palette too (#17335)

Exactly the same as #17247, but also just applied to the command palette. It's so much better guys.
microsoft · May 29, 2024 · a7c99be · a7c99be
1 parent 0bd0eea
commit a7c99be
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 19 deletions.
diff --git a/src/cascadia/TerminalApp/App.xaml b/src/cascadia/TerminalApp/App.xaml
@@ -146,6 +146,25 @@
                         </Setter>
                     </Style>
 
+                    <!--
+                        Remove all item animations from the suggestions UI and command
+                        palette. They're entirely too slow to let that UI be usable.
+                    -->
+                    <Style x:Key="NoAnimationsPlease"
+                           TargetType="ListView">
+                        <Setter Property="ItemContainerTransitions">
+                            <Setter.Value>
+                                <TransitionCollection>
+                                    <!--  (deleted transitions are left for reference for what we removed)  -->
+                                    <ContentThemeTransition />
+                                    <!--<AddDeleteThemeTransition/>-->
+                                    <!--<ReorderThemeTransition/>-->
+                                    <!--<EntranceThemeTransition IsStaggeringEnabled="False"/>-->
+                                </TransitionCollection>
+                            </Setter.Value>
+                        </Setter>
+                    </Style>
+
                     <ResourceDictionary.ThemeDictionaries>
                         <ResourceDictionary x:Key="Dark">
                             <!--  Define resources for Dark mode here  -->

diff --git a/src/cascadia/TerminalApp/CommandPalette.xaml b/src/cascadia/TerminalApp/CommandPalette.xaml
@@ -403,7 +403,8 @@
                       ItemClick="_listItemClicked"
                       ItemsSource="{x:Bind FilteredActions}"
                       SelectionChanged="_listItemSelectionChanged"
-                      SelectionMode="Single" />
+                      SelectionMode="Single"
+                      Style="{StaticResource NoAnimationsPlease}" />
 
         </Grid>
 

diff --git a/src/cascadia/TerminalApp/SuggestionsControl.xaml b/src/cascadia/TerminalApp/SuggestionsControl.xaml
@@ -100,24 +100,6 @@
                                                GeneralItemTemplate="{StaticResource GeneralItemTemplate}"
                                                NestedItemTemplate="{StaticResource NestedItemTemplate}" />
 
-            <!--
-                Remove all item animations from the suggestions UI. They're
-                entirely too slow to let that UI be usable.
-            -->
-            <Style x:Key="NoAnimationsPlease"
-                   TargetType="ListView">
-                <Setter Property="ItemContainerTransitions">
-                    <Setter.Value>
-                        <TransitionCollection>
-                            <!--  (deleted transitions are left for reference for what we removed)  -->
-                            <ContentThemeTransition />
-                            <!--<AddDeleteThemeTransition/>-->
-                            <!--<ReorderThemeTransition/>-->
-                            <!--<EntranceThemeTransition IsStaggeringEnabled="False"/>-->
-                        </TransitionCollection>
-                    </Setter.Value>
-                </Setter>
-            </Style>
         </ResourceDictionary>
     </UserControl.Resources>