Remove the animations from the suggestions UI #17247
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Remove all item animations from the suggestions UI. They're | ||
| entirely too slow to let that UI be usable. | ||
| --> | ||
| <Style x:Key="NoAnimationsPls" |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
| @@ -203,7 +222,10 @@ | |||
| ItemClick="_listItemClicked" | |||
| ItemsSource="{x:Bind FilteredActions}" | |||
| SelectionChanged="_listItemSelectionChanged" | |||
| SelectionMode="Single" /> | |||
| SelectionMode="Single" | |||
| Style="{StaticResource NoAnimationsPls}"> | |||
Check failure
Code scanning / check-spelling
Unrecognized Spelling
| @@ -12,6 +12,7 @@ | |||
| xmlns:model="using:Microsoft.Terminal.Settings.Model" | |||
| xmlns:mtu="using:Microsoft.Terminal.UI" | |||
| xmlns:mux="using:Microsoft.UI.Xaml.Controls" | |||
| MinWidth="256" | |||
There was a problem hiding this comment.
Does it need to be this much, or can we let the width get adjusted dynamically as a percentage of the page width? Do we need a MaxWidth?
There was a problem hiding this comment.
Ah, that was an unrelated nit that snuck in accidentally. IMO this makes it feel a lot smoother, since the width doesn't snap back and forth. The placeholder text makes the menu open at like, 252px or something, but then filtering the menu usually immediately makes it quite a bit narrower. This keeps the width a bit more consistent
|
Exactly the same as #17247, but also just applied to the command palette. It's so much better guys.
gotta go fast, and these animations are not fast
noted in #15845