Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all the feature flag code for the editable actions page in the SUI #11482

Closed
PankajBhojwani opened this issue Oct 12, 2021 · 0 comments · Fixed by #11576
Closed

Remove all the feature flag code for the editable actions page in the SUI #11482

PankajBhojwani opened this issue Oct 12, 2021 · 0 comments · Fixed by #11576
Assignees
@carlos-zamora
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@PankajBhojwani
Copy link
Contributor

Now that we are moving towards having the actions always be editable, we should go ahead and remove all the feature flag code related to it to reduce our code complexity/improve our code readability.
@PankajBhojwani PankajBhojwani added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Oct 12, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 12, 2021
@carlos-zamora carlos-zamora added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 12, 2021
@carlos-zamora carlos-zamora mentioned this issue Oct 21, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 21, 2021
@ghost ghost closed this as completed in #11576 Oct 25, 2021
ghost pushed a commit that referenced this issue Oct 25, 2021
@carlos-zamora
Remove feature flag code for editable actions page (#11576)
e10e1d8 
## Summary of the Pull Request
Removes the feature flag code for the editable actions page. Pretty straightforward.

## PR Checklist
Closes #11482
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove feature flag code for editable actions page microsoft/terminal
2 participants
@carlos-zamora @PankajBhojwani