Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated tab should be next to original tab #14313

Closed
OlafvdSpek opened this issue Oct 31, 2022 · 4 comments · Fixed by #14521
Closed

Duplicated tab should be next to original tab #14313

OlafvdSpek opened this issue Oct 31, 2022 · 4 comments · Fixed by #14521
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@OlafvdSpek
Copy link

Currently the duplicated tab is added on the far right, IMO it should be next to the original tab.
@OlafvdSpek OlafvdSpek added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 31, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 31, 2022
@lhecker
Copy link
Member

lhecker commented Nov 2, 2022

We have a setting for that! You can find it here:
image

Let me know if I misunderstood you. 🙂

@lhecker lhecker closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
@lhecker lhecker added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 2, 2022
@OlafvdSpek
Copy link
Author

When was that setting added? My 1.15 doesn't have it.
Also, duplicated tabs should be created next to the one being duplicated, while new tabs should be created after the last tab. How would that work?

@lhecker
Copy link
Member

lhecker commented Nov 2, 2022

This was introduced in #13421 which is part of 1.16 (currently in Windows Terminal Preview).

Also, duplicated tabs should be created next to the one being duplicated, while new tabs should be created after the last tab. How would that work?

Ah now I got it!

@lhecker lhecker reopened this Nov 2, 2022
@lhecker lhecker added Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting and removed Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels Nov 2, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Nov 7, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. good first issue This is a fix that might be easier for someone to do as a first contribution and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 7, 2022
@vamsiikrishnaak vamsiikrishnaak mentioned this issue Dec 10, 2022
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 10, 2022
@ghost ghost closed this as completed in #14521 Jan 4, 2023
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 4, 2023
ghost pushed a commit that referenced this issue Jan 4, 2023
@vamsiikrishnaak
Duplicated tabs open next to the current tab (#14521)
2d66dc4 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Added an additional optional parameter that indicates the position of the new tab being created.

https://user-images.githubusercontent.com/17508246/206831900-d8349fb6-4241-4c37-8dd8-e1645ba94c90.mp4

https://user-images.githubusercontent.com/17508246/206831949-02e4156e-f471-4d2f-b54b-3b0d294c62fe.mp4


<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #14313 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Tests added/passed

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
An optional parameter is added to TerminalPage::_CreateNewTabPane() and TerminalPage::_InitializeTab() which indicates the insert position of the duplicated tab.
During a new tab creation (not duplicate), this optional parameter has a default value(-1) and the new tab is inserted at the end.
The duplicated tab is inserted next to the original one even if it is not focused.

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Created different tabs and duplicated them.
Duplicated tabs that are focused and not focused.
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Jan 16, 2023
Open
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14521, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Duplicated tabs open next to the current tab
3 participants
@OlafvdSpek @lhecker @zadjii-msft