Duplicated tabs open next to the current tab

[vamsiikrishnaak]

Summary of the Pull Request

Added an additional optional parameter that indicates the position of the new tab being created.

TerminalDuplicateTabIssue_BeforeFix.mp4

TerminalDuplicateTabIssue_AfterFix.mp4

PR Checklist

• Closes Duplicated tab should be next to original tab #14313
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed

Detailed Description of the Pull Request / Additional comments

An optional parameter is added to TerminalPage::_CreateNewTabPane() and TerminalPage::_InitializeTab() which indicates the insert position of the duplicated tab.
During a new tab creation (not duplicate), this optional parameter has a default value(-1) and the new tab is inserted at the end.
The duplicated tab is inserted next to the original one even if it is not focused.

Validation Steps Performed

Created different tabs and duplicated them.
Duplicated tabs that are focused and not focused.

[vamsiikrishnaak]

@microsoft-github-policy-service agree

[DHowett]

Thanks for the contribution! Sorry for the delay in reviewing it. As we enter the holidays, we're going to be running a bit short-staffed. 😄

[DHowett]

@zadjii-msft I am 100% okay saying "duplicated tabs open next to the current tab" actually...

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[noheromen]

Hi, I know this issue is closed, but I actually find it annoying. I liked that duplicate tabs would open at the end... not next to the one that is duplicated. Can you please provide setting, where this can be changed between two options?