Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text entry closes when using context menu. #8975

Closed
DaMammoth opened this issue Jan 31, 2021 · 2 comments
Closed

Text entry closes when using context menu. #8975

DaMammoth opened this issue Jan 31, 2021 · 2 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@DaMammoth
Copy link

Windows build number: [Version 10.0.19042.746]
Windows Terminal version: 1.5.10271.0
This isn't a serious issue, but is annoying.

To reproduce

Open a new tab, then select "rename", on the context menu. Next, enter some text, then press Right Click or the context menu button on your keyboard (You may have to highlight text). It will close the context menu without warning.

Expected behavior

You should have the ability to open the context menu without it closing.

Actual behavior

The context menu closes instead of staying open, even though there are "cut", "paste", and "copy" options.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 31, 2021
@Don-Vito
Copy link
Contributor

Yep - annoying for sure 😊 I will commit a fix later on today.

@Don-Vito Don-Vito mentioned this issue Jan 31, 2021
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 31, 2021
@ghost ghost closed this as completed in 636f436 Feb 1, 2021
DHowett pushed a commit that referenced this issue Feb 5, 2021
@Don-Vito @DHowett
Prevent context menu of tab renamer text box from canceling edit (#8979)
1c0bbe7 
## PR Checklist
* [x] Closes #8975
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

## Detailed Description of the Pull Request / Additional comments
* We dismiss the edit each time `HeaderRenamerTextBox` loses focus
* Unfortunately, this applies also to scenario where the context menu
(copy, paste, select, etc.) is open with the right-click
* The fix is to ignore focus loss if `HeaderRenamerTextBox().ContextFlyout()` is open.
* We can do it as upon the fly-out dismiss the text box regains the focus.

![RenamerContextMenu](https://user-images.githubusercontent.com/4639110/106394866-90b10100-6407-11eb-8e92-627be4f70500.gif)

(cherry picked from commit 636f436)
@ghost
Copy link

ghost commented Feb 11, 2021

🎉This issue was addressed in #8979, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Don-Vito @DaMammoth