Prevent context menu of tab renamer text box from canceling edit #8979
Conversation
ghost
requested review from
miniksa,
carlos-zamora,
DHowett,
leonMSFT and
PankajBhojwani
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
| // If the context menu associated with the renamer text box is open we know it gained the focus. | ||
| // In this case we ignore this event (we will regain the focus once the menu will be closed). | ||
| const auto flyout = HeaderRenamerTextBox().ContextFlyout(); | ||
| if (flyout && flyout.IsOpen()) |
There was a problem hiding this comment.
qq: this doesn't make it so if you open the flyout and then navigate away from the box by clicking the terminal or something that the renamer stays open, right?
There was a problem hiding this comment.
Emm.. this is a default behavior of the context flyout - to return to the previously focused element when collapsed (as collapse might happen also because "paste" was chosen). I mean, we do not cancel focus loss in this code and preserve default behavior.
There was a problem hiding this comment.
Holy crap, I just got autocorrected! I meant to type “idle” thoughts. 😬
## PR Checklist * [x] Closes #8975 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments * We dismiss the edit each time `HeaderRenamerTextBox` loses focus * Unfortunately, this applies also to scenario where the context menu (copy, paste, select, etc.) is open with the right-click * The fix is to ignore focus loss if `HeaderRenamerTextBox().ContextFlyout()` is open. * We can do it as upon the fly-out dismiss the text box regains the focus.  (cherry picked from commit 636f436)
|
🎉 Handy links: |
ghost
mentioned this pull request
PR Checklist
Detailed Description of the Pull Request / Additional comments
HeaderRenamerTextBoxloses focus(copy, paste, select, etc.) is open with the right-click
HeaderRenamerTextBox().ContextFlyout()is open.