[defapp] Reconcile with process model/monarch-peasant glomming #9475
Assignees
Labels
Area-DefApp
Area-Server
Down in the muck of API call servicing, interprocess communication, eventing, etc.
Area-User Interface
Issues pertaining to the user interface of the Console or Terminal
Issue-Task
It's a feature request, but it doesn't really need a major design.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Milestone
Comments
ghost
added
Needs-Triage
miniksa
added
Area-Server
miniksa
removed
the
Needs-Triage
Merged
4 tasks
ghost
pushed a commit
that referenced
this issue
May 24, 2021
…n for connections (#10170) [Defapp] Use real HPCON for PTY management; Have Monarch always listen for connections ## PR Checklist * [x] Closes #9464 * [x] Related to #9475 - incomplete fix * [x] I work here. * [x] Manual test ## Detailed Description of the Pull Request / Additional comments - Sometimes peasants can't manage to accept a connection appropriately because I wrote defterm before @zadjii-msft's monarch/peasant architecture. The simple solution here is to just make the monarch always be listening for inbound connections. Then COM won't start a peasant with -Embedding just to ask the monarch where it should go. It'll just join the active window. I didn't close 9475 because it should follow monarch policies on which window to join... and it doesn't yet. - A lot of interesting things are happening because this didn't have a real HPCON. So I passed through the remaining handles (and re-GUID-ed the interface) that made it possible for me to pack the right process handles and such into an HPCON on the inbound connection and monitor that like any other ConptyConnection. This should resolve some of the process exit behaviors and signal channel things like resizing.
|
resolved by #10823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How does this work with process model/monarch-peasant glomming
Originally posted by @DHowett in #7489 (comment)
My reply was to probably make the monarch register itself to receive inbound connections like the
-Embeddingflag will do when COM cannot find a server and then follow the existing glom rules.The text was updated successfully, but these errors were encountered: