Add icon to profile title on settings UI

[cinnamon-msft]

Description of the new feature/enhancement

If would be cool if we displayed the icon of the profile at the top of the profile page on the settings UI.

Proposed technical implementation details (optional)

[vastatio-xoxo]

Hi, do you have any UI mockups (for dimensions, spacings etc) for the icon?

[HimanshuMahto]

Hey can you assign this to me

[zadjii-msft]

@HimanshuMahto Let us know if you need any help ☺️

[HimanshuMahto]

Since I'm new to this can you help me @zadjii-msft

[zadjii-msft]

Sure thing! I'd start by looking at #10046. That was an earlier attempt to do this, which we ultimately reverted in #10124. We had to revert that due to some crash when you saved the settings, but I'm thinking that crash is probably no longer applicable?

Now, the thing is, we've kinda re-written the settings UI since that original PR. It's still structurally pretty much the same, but there's been some minor changes to account for the Windows 11 style differences. You'll probably still want to put the icon in:

terminal/src/cascadia/TerminalSettingsEditor/MainPage.xaml

Lines 67 to 98 in 1745857

	<muxc:NavigationView x:Name="SettingsNav"
	Background="{ThemeResource SettingsPageBackground}"
	IsBackButtonVisible="Collapsed"
	IsSettingsVisible="False"
	ItemInvoked="SettingsNav_ItemInvoked"
	Loaded="SettingsNav_Loaded"
	TabFocusNavigation="Cycle">
	<muxc:NavigationView.Resources>
	<ResourceDictionary>
	<Thickness x:Key="NavigationViewHeaderMargin">15,0,0,0</Thickness>
	</ResourceDictionary>
	</muxc:NavigationView.Resources>
	<muxc:NavigationView.Header>
	<muxc:BreadcrumbBar x:Name="NavigationBreadcrumbBar"
	MaxWidth="{StaticResource StandardControlMaxWidth}"
	ItemClicked="BreadcrumbBar_ItemClicked"
	ItemsSource="{x:Bind Breadcrumbs}">
	<muxc:BreadcrumbBar.ItemTemplate>
	<DataTemplate x:DataType="local:Breadcrumb">
	<TextBlock Text="{x:Bind Label}" />
	</DataTemplate>
	</muxc:BreadcrumbBar.ItemTemplate>
	<muxc:BreadcrumbBar.Resources>
	<ResourceDictionary>
	<x:Double x:Key="BreadcrumbBarItemThemeFontSize">28</x:Double>
	<Thickness x:Key="BreadcrumbBarChevronPadding">11,4,12,0</Thickness>
	<FontWeight x:Key="BreadcrumbBarItemFontWeight">SemiBold</FontWeight>
	<x:Double x:Key="BreadcrumbBarChevronFontSize">16</x:Double>
	</ResourceDictionary>
	</muxc:BreadcrumbBar.Resources>
	</muxc:BreadcrumbBar>
	</muxc:NavigationView.Header>

[HimanshuMahto]

okay, I got it. hey, Can I get your contact so that I can ask you questions in person if you don't mind? @zadjii-msft

[zadjii-msft]

To be totally honest - I'd prefer to keep discussion on GitHub. Reasons include (but aren't limited to):

1. I'm terrible at replying to mails. There's just too much volume, and I'm known to read an email, not immediately reply, then forget about it. I'm somehow better about replying to GitHub
2. No one should judge anyone for asking questions. Ever. How could anyone ever learn anything without starting by asking questions?
3. If you have questions about contributing to the Terminal (or really any part of our dev stack here), then chances are, others will too. Better to leave an archive of notes for future people to learn from too ☺️

[HimanshuMahto]

okay, thanks for the advice.

[HimanshuMahto]

Hey, @zadjii-msft I'm new to this and don't know how to run and see the changes though I have installed powershell pro tools and powershell in the VS code and did try to run the code but it wasn't showing anything. Can you please help me. I know its a silly question but I don't know how to do it and want to learn want to contribute to this.

[HimanshuMahto]

Hey @zadjii-msft @DHowett @cinnamon-msft need a help

[zadjii-msft]

@HimanshuMahto Did you try following these steps in the README?

Once you've got the code checked out and the tools installed, the easiest way to test the code is to open up OpenConsole.sln, set the config to

(or x86 if you're on an x86 machine for some reason)

and hit the big green play button to start debugging.

[HimanshuMahto]

Got it @zadjii-msft. Thanks a lot i will start working on it.

[HimanshuMahto]

Hey, @zadjii-msft, I tried what you said but its still not working.

[rohiitgit]

Hii, seems like the last person was unsuccessful at this. Can you assign this to me? It will be my first issue.

[zadjii-msft]

You can just go ahead and start working on things without necessarily being assigned. Usually we really only use the Assignees field if someone on the core team has to be the one to deal with an issue 😝

[Kore-rep]

Hi @zadjii-msft, pretty much done with the implementation of this (i.e. just kinda copying your old code across). Did you ever manage to overcome the resolution scaling issues? The font icons look fine, but the powershell icon, when scaled up to a height of 28 looks quite horrible.