Skip to content

Conversation

@carlos-zamora
Copy link
Member

This reverts commit a3a2a41.

#10046 causes a crash on save. MainPage::UpdateSettings() is unable to update the navigation view's selected item due to an "incorrect parameter". This is particularly strange to see because #10046 only modifies the navigation view's header, not the menu items themselves. Reverting this change fixes that crash (verified).

Reopens #9694

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine reverting this, but I'd love to understand why. Presumably we'll need to do this eventually, right? Is there a particular item that it's selecting that causes this crash?

@carlos-zamora
Copy link
Member Author

I'm fine reverting this, but I'd love to understand why. Presumably we'll need to do this eventually, right? Is there a particular item that it's selecting that causes this crash?

This would happen with the startup page, which was honestly like not affected at all by this. I'm assuming the same would happen with the profile page as well, but that's not verified.

@carlos-zamora carlos-zamora added AutoMerge Marked for automatic merge by the bot when requirements are met Priority-0 Bugs that we consider release-blocking/recall-class (P0) Severity-Crash Crashes are real bad news. labels May 18, 2021
@ghost
Copy link

ghost commented May 18, 2021

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 16 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented May 18, 2021

1 s/o for a revert

@DHowett DHowett merged commit 996a680 into main May 18, 2021
@DHowett DHowett deleted the dev/cazamor/revert-page-header-icons branch May 18, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Marked for automatic merge by the bot when requirements are met Priority-0 Bugs that we consider release-blocking/recall-class (P0) Severity-Crash Crashes are real bad news.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants