Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only access ControlInteractivity through the projection #10051

Merged
merged 46 commits into from
Jul 19, 2021
Merged

Only access ControlInteractivity through the projection #10051

merged 46 commits into from
Jul 19, 2021

Commits on Apr 29, 2021

  1. Only access ControlInteractivity through the projection

    @zadjii-msft
    zadjii-msft committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    e4478ee View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. Only 24 more errors to go

    @zadjii-msft
    zadjii-msft committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    400b35f View commit details
    Browse the repository at this point in the history

  2. Totally upend the control AutomationPeer workings 

      Now we have an InteractivityAutomationPeer, which acts like the implementation for TermControlAutomationPeer.

  TermControlAutomationPeer is still needed though, because it implements FrameworkElementAutomationPeer, which is needed to hook up the AP to the actual UIA tree.

  So we split up the work into two halves, the bit that should be done by the core (the ITextProvider, the IControlAccessibilityInfo), vs the stuff that needs to be in the control (FrameworkElementAutomationPeer). IUiaEventDispatcher should probably be in the control as well, but that's a problem for future us.
    @zadjii-msft
    zadjii-msft committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    42b970b View commit details
    Browse the repository at this point in the history

  3. some comments that should have been in the previous commit. 16 errors… 

    … remain.
    @zadjii-msft
    zadjii-msft committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    4578c13 View commit details
    Browse the repository at this point in the history

  4. GetHoveredCell/UpdateHoveredCell. 12 remain.

    @zadjii-msft
    zadjii-msft committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    d8cc047 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Revert "Revert "Use DComp surface handle for Swap Chain management."" 

    This reverts commit c113b65.

That commit reverted 30b8335
    @zadjii-msft
    zadjii-msft committed May 3, 2021
    Configuration menu
    Copy the full SHA
    21a97b6 View commit details
    Browse the repository at this point in the history

  2. some minor cleanup

    @zadjii-msft
    zadjii-msft committed May 3, 2021
    Configuration menu
    Copy the full SHA
    2e861d8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev/migrie/f/oop/use-dcomp-handle' into dev/migrie/inte… 

    …ractivity-projection-000
    @zadjii-msft
    zadjii-msft committed May 3, 2021
    Configuration menu
    Copy the full SHA
    e20caae View commit details
    Browse the repository at this point in the history

  4. Use the HANDLE for the swapchainin the core projection

    @zadjii-msft
    zadjii-msft committed May 3, 2021
    Configuration menu
    Copy the full SHA
    d667f3b View commit details
    Browse the repository at this point in the history

  5. it builds and runs so I guess it's done now

    @zadjii-msft
    zadjii-msft committed May 3, 2021
    Configuration menu
    Copy the full SHA
    62cbf30 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Do the delayload dance

    @zadjii-msft
    zadjii-msft committed May 6, 2021
    Configuration menu
    Copy the full SHA
    445bdf6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/migrie/f/oop/use-dcomp-handle' into dev/migrie/inte… 

    …ractivity-projection-000
    @zadjii-msft
    zadjii-msft committed May 6, 2021
    Configuration menu
    Copy the full SHA
    1376721 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. What a ridiculous hack

    @zadjii-msft
    zadjii-msft committed May 7, 2021
    Configuration menu
    Copy the full SHA
    a1ce7cb View commit details
    Browse the repository at this point in the history

  2. fix accessibility

    @zadjii-msft
    zadjii-msft committed May 7, 2021
    Configuration menu
    Copy the full SHA
    03fb764 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000

# Conflicts:
#	src/cascadia/TerminalControl/ControlInteractivity.cpp
#	src/cascadia/TerminalControl/ControlInteractivity.h
#	src/cascadia/TerminalControl/TermControl.cpp
#	src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp
    @zadjii-msft
    zadjii-msft committed May 7, 2021
    Configuration menu
    Copy the full SHA
    5e7d270 View commit details
    Browse the repository at this point in the history

  4. I want to get the padding out of interactivity, but the control bound… 

    …s are still wrong
    @zadjii-msft
    zadjii-msft committed May 7, 2021
    Configuration menu
    Copy the full SHA
    6e031e5 View commit details
    Browse the repository at this point in the history

  5. now this works!

    @zadjii-msft
    zadjii-msft committed May 7, 2021
    Configuration menu
    Copy the full SHA
    47410c9 View commit details
    Browse the repository at this point in the history

  6. Some cleanup

    @zadjii-msft
    zadjii-msft committed May 7, 2021
    1 Configuration menu
    Copy the full SHA
    0869456 View commit details
    Browse the repository at this point in the history

  7. a bit more cleanup

    @zadjii-msft
    zadjii-msft committed May 7, 2021
    Configuration menu
    Copy the full SHA
    dace0c4 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into dev/migrie/f/oop/use-… 

    …dcomp-handle
    @zadjii-msft
    zadjii-msft committed May 7, 2021
    Configuration menu
    Copy the full SHA
    12b78f5 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'dev/migrie/f/oop/use-dcomp-handle' into dev/migrie/inte… 

    …ractivity-projection-000
    @zadjii-msft
    zadjii-msft committed May 7, 2021
    1 Configuration menu
    Copy the full SHA
    e340fe9 View commit details
    Browse the repository at this point in the history

  10. god I knew I left these behind

    @zadjii-msft
    zadjii-msft committed May 7, 2021
    1 Configuration menu
    Copy the full SHA
    b7b23a8 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed May 12, 2021
    Configuration menu
    Copy the full SHA
    086710a View commit details
    Browse the repository at this point in the history

  2. fix the tests

    @zadjii-msft
    zadjii-msft committed May 12, 2021
    Configuration menu
    Copy the full SHA
    21a6370 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. This fixes nvda, so nowwe just have to polish

    @zadjii-msft
    zadjii-msft committed May 13, 2021
    Configuration menu
    Copy the full SHA
    4efdf39 View commit details
    Browse the repository at this point in the history

  2. minor typo cleanup

    @zadjii-msft
    zadjii-msft committed May 13, 2021
    Configuration menu
    Copy the full SHA
    59e911d View commit details
    Browse the repository at this point in the history

  3. some consts

    @zadjii-msft
    zadjii-msft committed May 13, 2021
    Configuration menu
    Copy the full SHA
    6f07004 View commit details
    Browse the repository at this point in the history

  4. this is almost exclusively nits

    @zadjii-msft
    zadjii-msft committed May 13, 2021
    Configuration menu
    Copy the full SHA
    ff3b808 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. simple nits

    @zadjii-msft
    zadjii-msft committed May 20, 2021
    Configuration menu
    Copy the full SHA
    559d1de View commit details
    Browse the repository at this point in the history

  2. this one's easy too

    @zadjii-msft
    zadjii-msft committed May 20, 2021
    Configuration menu
    Copy the full SHA
    804a114 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. An enum does in fact work across the process boundary 

    (cherry picked from commit 7fc72ca)
    @zadjii-msft
    zadjii-msft committed May 21, 2021
    Configuration menu
    Copy the full SHA
    0f0af03 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed May 21, 2021
    Configuration menu
    Copy the full SHA
    95300d4 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed May 24, 2021
    Configuration menu
    Copy the full SHA
    1de9485 View commit details
    Browse the repository at this point in the history

  2. fix the build

    @zadjii-msft
    zadjii-msft committed May 24, 2021
    Configuration menu
    Copy the full SHA
    1bc27d0 View commit details
    Browse the repository at this point in the history

  3. chances are, this will fix the x86 build

    @zadjii-msft
    zadjii-msft committed May 24, 2021
    Configuration menu
    Copy the full SHA
    3cace60 View commit details
    Browse the repository at this point in the history

  4. I am ashamed, this should not be there

    @zadjii-msft
    zadjii-msft committed May 24, 2021
    Configuration menu
    Copy the full SHA
    265bd9f View commit details
    Browse the repository at this point in the history

  5. Port the automation peer crash fix to this branch, @carlos-zamora

    @zadjii-msft
    zadjii-msft committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c8a2957 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. The comment literally says to put this first. Why didn't I put this f… 

    …irst
    @zadjii-msft
    zadjii-msft committed May 25, 2021
    Configuration menu
    Copy the full SHA
    074f67c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5a0840a View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @DHowett
    DHowett committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    f5665c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    056c354 View commit details
    Browse the repository at this point in the history

  2. minor nits from carlos

    @zadjii-msft
    zadjii-msft committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e643885 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev/migrie/interactivity-projection-000' of https://git… 

    …hub.com/microsoft/terminal into dev/migrie/interactivity-projection-000
    @zadjii-msft
    zadjii-msft committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    33653e0 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3d59a67 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    5a598f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/interactiv… 

    …ity-projection-000
    @zadjii-msft
    zadjii-msft committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    3797d52 View commit details
    Browse the repository at this point in the history