Replace the placeholder release build with our real one #10778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Convert all queue-time variables into form-based parameters - Add a "matrix" build strategy for Configs * Platforms - Rename all jobs to have reasonable names - The YAML generator has a bug where it inlines scripts *and* file paths if a task had both; remove old inlines - Remove dead rules
|
The new build execution UI is very nice:
|
remove PR conditions
carlos-zamora
approved these changes
Jul 26, 2021
Comment on lines
+112
to
+125
| resourceFilePath: >- | ||
| src\cascadia\TerminalApp\Resources\en-US\Resources.resw | ||
|
|
||
| src\cascadia\TerminalControl\Resources\en-US\Resources.resw | ||
|
|
||
| src\cascadia\TerminalConnection\Resources\en-US\Resources.resw | ||
|
|
||
| src\cascadia\TerminalSettingsModel\Resources\en-US\Resources.resw | ||
|
|
||
| src\cascadia\TerminalSettingsEditor\Resources\en-US\Resources.resw | ||
|
|
||
| src\cascadia\WindowsTerminalUniversal\Resources\en-US\Resources.resw | ||
|
|
||
| src\cascadia\CascadiaPackage\Resources\en-US\Resources.resw |
There was a problem hiding this comment.
We're not allowed to use wildcards here? Like, src\cascadia\*\Resources\en-US\Resources.resw
There was a problem hiding this comment.
we probably can, but i'd rather not mess with steps that are working
miniksa
approved these changes
Jul 27, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
added a commit
that referenced
this pull request
Aug 25, 2021
This pull request ports our old release pipeline from Azure DevOps' editor to real YAML. It includes the following changes on top of a straight-up "export" from Azure: - Converts all queue-time variables into form-based parameters - Adds a "matrix" build strategy for Configs * Platforms - Renames all jobs to have reasonable names - The YAML generator has a bug where it inlines scripts *and* file paths if a task had both; remove old inlines - Removes dead rules - Fixes the WPF build to include the apiset impostor - Migrates the access token into the environment for the one build stage that needs it - Cleans up some of the online script logic - Removes all of the "!is pull request?" checks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ports our old release pipeline from Azure DevOps' editor to real YAML.
It includes the following changes on top of a straight-up "export" from Azure: