Allow for exe/dll paths for the Icon setting

[PankajBhojwani]

Summary of the Pull Request

Allow exe/dll paths for the Icon setting

The exe/dll icon needs to work in all the following areas:

• The tab
• The navigation view item in the SUI
• The new tab flyout
• The command palette

PR Checklist

• Closes Support exe/dll paths in the 'icon' setting #1504
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated.
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

For the command palette, we had to switch to using ContentPresenter because IconSourceElement cannot take in every type of icon we need to provide

Validation Steps Performed

Setting "%SystemRoot%\System32\shell32.dll,214" as the icon for a profile works in all the cases listed above.

[PankajBhojwani]

Taking over this feature since @zadjii-msft is going to be OOF for a while. Currently have it working for everything except the command palette, which is proving to be quite annoying because we cannot just declare an IconElement in xaml, we have to specify a child class of IconElement such as IconSourceElement / FontIcon or the like, which each take in a specific source type (whereas we need to be able to use both IconSource and SoftwareBitmapSource)

[carlos-zamora]

I think basically all of the comments are nits. I definitely want somebody to take a closer look at the async stuff, but other than that, nothing concerns me here :)

[zadjii-msft]

from bug bash:

font icons are now tiny, here and in the SUI.

[PankajBhojwani]

font icons are now tiny, here and in the SUI.

Thanks for the catch, fixed now!

[zadjii-msft]

god bless you for figuring out how to align the different icon types.

[carlos-zamora]

@msftbot merge this in 10 minutes

[ghost]

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Wed, 26 Oct 2022 18:11:08 GMT, which is in 10 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[silkfire]

Which version will this be released in?

[zadjii-msft]

The next release will be 1.17 Preview. No specific ETA on that yet - it'll be done when it's done 😉

[ghost]

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download