-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for exe/dll paths for the Icon setting #14107
Conversation
Taking over this feature since @zadjii-msft is going to be OOF for a while. Currently have it working for everything except the command palette, which is proving to be quite annoying because we cannot just declare an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think basically all of the comments are nits. I definitely want somebody to take a closer look at the async stuff, but other than that, nothing concerns me here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch, fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
god bless you for figuring out how to align the different icon types.
This comment was marked as spam.
This comment was marked as spam.
@msftbot merge this in 10 minutes |
Hello @carlos-zamora! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Which version will this be released in? |
The next release will be 1.17 Preview. No specific ETA on that yet - it'll be done when it's done 😉 |
🎉 Handy links: |
Summary of the Pull Request
Allow exe/dll paths for the
Icon
settingThe exe/dll icon needs to work in all the following areas:
PR Checklist
Detailed Description of the Pull Request / Additional comments
For the command palette, we had to switch to using
ContentPresenter
becauseIconSourceElement
cannot take in every type of icon we need to provideValidation Steps Performed
Setting "%SystemRoot%\System32\shell32.dll,214" as the icon for a profile works in all the cases listed above.