Resize our ContentDialog's when the window resizes #14722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 51 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
requested review from
carlos-zamora
approved these changes
Jan 23, 2023
DHowett
reviewed
Jan 23, 2023
DHowett
pushed a commit
that referenced
this pull request
Jan 23, 2023
Major thanks to @dongle-the-gadget in microsoft/microsoft-ui-xaml#3577 (comment) for coming up with this workaround. This PR will manually forward a `WM_SIZE` message to our `CoreWindow`, to trigger the `ContentDialog` to resize itself. We always closed these issues as dupes of the upstream one, so this doesn't actually close anything. HOWEVER, these are the following issues that reported this bug: - #2380 - #4463 - #5252 - #5810 - #6181 - #7113 - #7225 - #8245 - #8496 - #8643 - #9336 - #9563 - #5808 - #10351 - #10634 - #10995 - #11770 - #13796 (cherry picked from commit a4cf4e2) Service-Card-Id: 87727806 Service-Version: 1.17
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major thanks to @dongle-the-gadget in microsoft/microsoft-ui-xaml#3577 (comment) for coming up with this workaround.
This PR will manually forward a
WM_SIZEmessage to ourCoreWindow, to trigger theContentDialogto resize itself.We always closed these issues as dupes of the upstream one, so this doesn't actually close anything.
HOWEVER, these are the following issues that reported this bug: