Add "legacy" themes #15108
Merged
Add "legacy" themes #15108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minimal version of the requests for #14858. In that thread we discussed FULL reverting the default themes to the old ones. In later discussion, we decided _meh_, let's just ship the legacy themes too, so it's easy to go back if you should choose. The default still remains the sane `dark`, but the `legacy*` themes are all right there, and given the same special treatment as the other inbox themes. Closes #14858 Closes #14844
microsoft-github-policy-service
bot
added
Issue-Task
|
New themes (fresh settings.json) "Light (Legacy)" "Light" |
DHowett
reviewed
Apr 4, 2023
src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp
Outdated
Show resolved
Hide resolved
DHowett
reviewed
Apr 4, 2023
| "name": "legacySystem", | ||
| "tab": | ||
| { | ||
| "background": null, |
There was a problem hiding this comment.
how does this even work? that's neat...
carlos-zamora
approved these changes
Apr 5, 2023
DHowett
approved these changes
Apr 6, 2023
DHowett
pushed a commit
that referenced
this pull request
Apr 11, 2023
DHowett
pushed a commit
that referenced
this pull request
Apr 14, 2023
This is a minimal version of the requests for #14858. In that thread we discussed FULL reverting the default themes to the old ones. In later discussion, we decided _meh_, let's just ship the legacy themes too, so it's easy to go back if you should choose. The default still remains the sane `dark`, but the `legacy*` themes are all right there, and given the same special treatment as the other inbox themes. Closes #14858 Closes #14844 (cherry picked from commit fe66ba5) Service-Card-Id: 88785748 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal version of the requests for #14858. In that thread we discussed FULL reverting the default themes to the old ones. In later discussion, we decided meh, let's just ship the legacy themes too, so it's easy to go back if you should choose. The default still remains the sane
dark, but thelegacy*themes are all right there, and given the same special treatment as the other inbox themes.Closes #14858
Closes #14844