Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix re-persisting the new legacy themes #15160

Merged
merged 2 commits into from Apr 11, 2023
Merged

Fix re-persisting the new legacy themes #15160

merged 2 commits into from Apr 11, 2023

Conversation

zadjii-msft
Copy link
Member

Yep, I forgot to not write them back to the settings file here.

Regressed in #15108

Closes #15152

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings Issues related to settings and customizability, for console or terminal Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Apr 11, 2023
DHowett
DHowett requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer Leonard's fun version - blocking :)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 11, 2023
DHowett added a commit that referenced this pull request Apr 11, 2023
@DHowett
PRE-MERGE #15160 Fix re-persisting the new legacy themes
05bc2d7
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 11, 2023
@DHowett DHowett merged commit b4f6503 into main Apr 11, 2023
15 checks passed
@DHowett DHowett deleted the dev/migrie/15152-whoops-all-themes branch April 11, 2023 22:10
DHowett added a commit that referenced this pull request Apr 14, 2023
@DHowett
PRE-MERGE #15160 Fix re-persisting the new legacy themes
f3e1170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.18: Terminal saves the "legacy" themes (!)
3 participants
@zadjii-msft @DHowett @lhecker