-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check spelling 0.0.22 #16127
Check spelling 0.0.22 #16127
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
0096300
to
abbfedb
Compare
@@ -6,8 +6,6 @@ | |||
|
|||
By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. | |||
|
|||
:warning: The command is written for posix shells. If it doesn't work for you, you can manually _add_ (one word per line) / _remove_ items to `expect.txt` and the `excludes.txt` files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the command should now work on Windows shells
# the negative lookahead here is to allow catching 'templatesz' as a misspelling | ||
# but to otherwise recognize a Windows path with \templates\foo.template or similar: | ||
\\(?:necessary|r(?:eport|esolve[dr]?|esult)|t(?:arget|emplates?))(?![a-z]) | ||
#\\(?:necessary|r(?:eport|esolve[dr]?|esult)|t(?:arget|emplates?))(?![a-z]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is no longer necessary in 0.0.22 as I removed the built-in \n
/\r
/\t
handling
\.zip$ | ||
^\.github/actions/spelling/ | ||
^\.github/fabricbot.json$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently fabricbot is gone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be removed once this PR merges, it's here to make the v0.0.21 engine happy. (I meant to include it in the initial PR, but missed a push...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(GitHub's definition of outdated is buggy, there's a github discussion where people complain about this poor behavior -- this comment is not outdated)
tags-ignore: | ||
- "**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was never supported by pull_request_target
as it / pull_request
never applied to tags.
@@ -1,6 +1,7 @@ | |||
^attache$ | |||
^attacher$ | |||
^attachers$ | |||
^bellow$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another archaic word I ran across... -- it's unlikely you'll want to reference stoking fires quite like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UGH THANK YOU
# latex | ||
\\(?:n(?:ew|ormal|osub)|r(?:enew)|t(?:able(?:of|)|he|itle))(?=[a-z]+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as check-spelling no longer special cases \n
/\r
/\t
, the workaround can be removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as check-spelling no longer special cases \n
/\r
/\t
, the workaround can be removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as check-spelling no longer special cases \n
/\r
/\t
, the workaround can be removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as check-spelling no longer special cases \n
/\r
/\t
, the workaround can be removed :)
AHH, I'm so excited! We might-could need to revert the changes under Thank you for doing this! |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This file can be deleted after this branch is merged.
abbfedb
to
f97210c
Compare
Okay, wow, I 100% didn't notice that you had done the oss/ and dep/ things. Dang it github! Force pushes are pushes too! I'll review and summarily merge |
This comment has been minimized.
This comment has been minimized.
not a XAML resource that controls this, nor is this something that's exposed by | ||
no XAML resource that controls this, nor is this something that's exposed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I like that pattern!
Ugh, I shouldnae've merged main. |
Summary of the Pull Request
Upgrades check-spelling to v0.0.22
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
\n
/\r
/\t
is removed -- This means that thepatterns/0_*.txt
files can be removed.allow/check-spelling-0.0.21.txt
-- once it this PR merges, it can be removed on a branch and the next CI will clean out items fromexpect.txt
relating to the\r
stuff and suggest replacement content.microsoft
vs.Microsoft
), there's now a specific category with help/adviceValidation Steps Performed
PR Checklist