Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persisting the size of a focus mode window #17068

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

zadjii-msft
Copy link
Member

While I was fixing the initial position thing, I figured I'd fix this too. We were mistakenly accounting for the size of the titlebar when we should launch into focus mode (without one)

Closes #10730

While I was fixing the initial position thing, I figured I'd fix this too. We
were mistakenly accounting for the size of the titlebar when we should launch
into focus mode (without one)

Closes #10730
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Apr 16, 2024
@DHowett
Copy link
Member

DHowett commented Apr 16, 2024

This may be (un)related to the other size persistence regression, but should we include it in 1.20?

@DHowett DHowett added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 23, 2024
@DHowett DHowett added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 23, 2024
@G1style

This comment was marked as spam.

@zadjii-msft zadjii-msft added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 24, 2024
@zadjii-msft zadjii-msft added this pull request to the merge queue Apr 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2024
@zadjii-msft zadjii-msft added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit f36d589 Apr 25, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/b/10730-fomo-resto branch April 25, 2024 12:54
DHowett pushed a commit that referenced this pull request Apr 26, 2024
While I was fixing the initial position thing, I figured I'd fix this
too. We were mistakenly accounting for the size of the titlebar when we
should launch into focus mode (without one)

Closes #10730

(cherry picked from commit f36d589)
Service-Card-Id: 92410732
Service-Version: 1.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
Development

Successfully merging this pull request may close these issues.

Launching in Focus mode doesn't start at the correct size
4 participants