Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove command's knowledge of its keys #17215

Merged
merged 96 commits into from
Jun 6, 2024
Merged

Remove command's knowledge of its keys #17215

merged 96 commits into from
Jun 6, 2024

Commits on Mar 5, 2024

  1. add origin tag

    @PankajBhojwani
    PankajBhojwani committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    90627b3 View commit details
    Browse the repository at this point in the history

  2. update calls in tests

    @PankajBhojwani
    PankajBhojwani committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9dff28f View commit details
    Browse the repository at this point in the history

  3. fix tests

    @PankajBhojwani
    PankajBhojwani committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8bcbd0b View commit details
    Browse the repository at this point in the history

  4. ah one of the tests uses this

    @PankajBhojwani
    PankajBhojwani committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    052d063 View commit details
    Browse the repository at this point in the history

  5. generated

    @PankajBhojwani
    PankajBhojwani committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    8cc82de View commit details
    Browse the repository at this point in the history

  6. inbox makes more sense

    @PankajBhojwani
    PankajBhojwani committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    642d0ab View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. default ids

    @PankajBhojwani
    PankajBhojwani committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    66fe08f View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. conflict

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    2bb1b6c View commit details
    Browse the repository at this point in the history

  2. merge origin

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    be193b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. generate IDs for user commands

    @PankajBhojwani
    PankajBhojwani committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    db528c9 View commit details
    Browse the repository at this point in the history

  2. nits

    @PankajBhojwani
    PankajBhojwani committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7c907fe View commit details
    Browse the repository at this point in the history

  3. spacing

    @PankajBhojwani
    PankajBhojwani committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b43191d View commit details
    Browse the repository at this point in the history

  4. line

    @PankajBhojwani
    PankajBhojwani committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    2093660 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. string of numbers is unsightly but it works

    @PankajBhojwani
    PankajBhojwani committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    6c32539 View commit details
    Browse the repository at this point in the history

  2. update comment

    @PankajBhojwani
    PankajBhojwani committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    eccd87f View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. move id generation to fixupusersettings

    @PankajBhojwani
    PankajBhojwani committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    44510dc View commit details
    Browse the repository at this point in the history

  2. this way is better

    @PankajBhojwani
    PankajBhojwani committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    10d1fc8 View commit details
    Browse the repository at this point in the history

  3. even better, also get the ID from json

    @PankajBhojwani
    PankajBhojwani committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    71bf90f View commit details
    Browse the repository at this point in the history

  4. move this

    @PankajBhojwani
    PankajBhojwani committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d57c7a1 View commit details
    Browse the repository at this point in the history

  5. fix test

    @PankajBhojwani
    PankajBhojwani committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5c2307c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. add tests

    @PankajBhojwani
    PankajBhojwani committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9fc6972 View commit details
    Browse the repository at this point in the history

  2. excess line

    @PankajBhojwani
    PankajBhojwani committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    dca7df5 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. change tests

    @PankajBhojwani
    PankajBhojwani committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    dd25ed7 View commit details
    Browse the repository at this point in the history

  2. Everytime

    @PankajBhojwani
    PankajBhojwani committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    6e293a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. defaults conflict

    @PankajBhojwani
    PankajBhojwani committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    af2d22f View commit details
    Browse the repository at this point in the history

  2. first round of nits

    @PankajBhojwani
    PankajBhojwani committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    bdf42c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. truncate and hex, debug assert

    @PankajBhojwani
    PankajBhojwani committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    12f3aa9 View commit details
    Browse the repository at this point in the history

  2. null check

    @PankajBhojwani
    PankajBhojwani committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    aa49212 View commit details
    Browse the repository at this point in the history

  3. fmt is smart

    @PankajBhojwani
    PankajBhojwani committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5ee630e View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. fmt_compile, fix test

    @PankajBhojwani
    PankajBhojwani committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    360b92e View commit details
    Browse the repository at this point in the history

  2. remove 0

    @PankajBhojwani
    PankajBhojwani committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5e70911 View commit details
    Browse the repository at this point in the history

  3. rename and comment

    @PankajBhojwani
    PankajBhojwani committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ca3eb87 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. midpoint

    @PankajBhojwani
    PankajBhojwani committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    85933e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. about to test stage 1

    @PankajBhojwani
    PankajBhojwani committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c134402 View commit details
    Browse the repository at this point in the history

  2. works??

    @PankajBhojwani
    PankajBhojwani committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    22ab936 View commit details
    Browse the repository at this point in the history

  3. edge cases

    @PankajBhojwani
    PankajBhojwani committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0a3e17e View commit details
    Browse the repository at this point in the history

  4. some todos for later

    @PankajBhojwani
    PankajBhojwani committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e28d478 View commit details
    Browse the repository at this point in the history

  5. remove keysmap

    @PankajBhojwani
    PankajBhojwani committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f425746 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. ugly way to make sure we fixup

    @PankajBhojwani
    PankajBhojwani committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d0938e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. shows up in sui and all keybindings work

    @PankajBhojwani
    PankajBhojwani committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    12a61c5 View commit details
    Browse the repository at this point in the history

  2. overwritten IDs and overwritten keychords show up properly in the SUI

    @PankajBhojwani
    PankajBhojwani committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f1633e0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/microsoft/terminal into dev… 

    …/pabhoj/action_refactor
    @PankajBhojwani
    PankajBhojwani committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ddfac90 View commit details
    Browse the repository at this point in the history

  4. sui works?

    @PankajBhojwani
    PankajBhojwani committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3e7ab38 View commit details
    Browse the repository at this point in the history

  5. started stage 3

    @PankajBhojwani
    PankajBhojwani committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ae16a5e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. rename to special/standard

    @PankajBhojwani
    PankajBhojwani committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    dc874c3 View commit details
    Browse the repository at this point in the history

  2. _getactionbyid no longer returns optional

    @PankajBhojwani
    PankajBhojwani committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    936afd6 View commit details
    Browse the repository at this point in the history

  3. remove check for invalid

    @PankajBhojwani
    PankajBhojwani committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    b3e9c26 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. reimplement populating all known keybindings

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5a1b822 View commit details
    Browse the repository at this point in the history

  2. unmark these

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c51558f View commit details
    Browse the repository at this point in the history

  3. mark gh todo

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    1 Configuration menu
    Copy the full SHA
    754bf04 View commit details
    Browse the repository at this point in the history

  4. update defaults

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2f1d8d2 View commit details
    Browse the repository at this point in the history

  5. don't check for special in standard

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2b4aeb2 View commit details
    Browse the repository at this point in the history

  6. some comments

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e62dfa2 View commit details
    Browse the repository at this point in the history

  7. resolve conflict

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e725f1e View commit details
    Browse the repository at this point in the history

  8. spelling things

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    db00b90 View commit details
    Browse the repository at this point in the history

  9. format

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3d92f27 View commit details
    Browse the repository at this point in the history

  10. remove _idwasgenerated

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    428821b View commit details
    Browse the repository at this point in the history

  11. fix user defaults file

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6437b9f View commit details
    Browse the repository at this point in the history

  12. misc

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4c744e6 View commit details
    Browse the repository at this point in the history

  13. only one tojson

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ca4015f View commit details
    Browse the repository at this point in the history

  14. just add duplicate pane auto to defaults

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    45cfcd6 View commit details
    Browse the repository at this point in the history

  15. remove _getcumulativeactions

    @PankajBhojwani
    PankajBhojwani committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3c6015d View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. bandaid temporary fix for name

    @PankajBhojwani
    PankajBhojwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c2c75c8 View commit details
    Browse the repository at this point in the history

  2. better if

    @PankajBhojwani
    PankajBhojwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3e601f5 View commit details
    Browse the repository at this point in the history

  3. mark todo

    @PankajBhojwani
    PankajBhojwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    cdb907d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/microsoft/terminal into dev… 

    …/pabhoj/action_refactor
    @PankajBhojwani
    PankajBhojwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f35bf20 View commit details
    Browse the repository at this point in the history

  5. check for name, fix some tests

    @PankajBhojwani
    PankajBhojwani committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2b16acd View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. fix remaining tests

    @PankajBhojwani
    PankajBhojwani committed May 2, 2024
    Configuration menu
    Copy the full SHA
    193e573 View commit details
    Browse the repository at this point in the history

  2. this is better

    @PankajBhojwani
    PankajBhojwani committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0480d65 View commit details
    Browse the repository at this point in the history

  3. correct GH todo

    @PankajBhojwani
    PankajBhojwani committed May 2, 2024
    Configuration menu
    Copy the full SHA
    02a1e37 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. some new tests

    @PankajBhojwani
    PankajBhojwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    80fc299 View commit details
    Browse the repository at this point in the history

  2. another test

    @PankajBhojwani
    PankajBhojwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ebc03e9 View commit details
    Browse the repository at this point in the history

  3. nits

    @PankajBhojwani
    PankajBhojwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ccf1cc9 View commit details
    Browse the repository at this point in the history

  4. schema

    @PankajBhojwani
    PankajBhojwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7793c5c View commit details
    Browse the repository at this point in the history

  5. move this to header

    @PankajBhojwani
    PankajBhojwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    abef25d View commit details
    Browse the repository at this point in the history

  6. schema conflict

    @PankajBhojwani
    PankajBhojwani committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4d35c14 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. generate here instead

    @PankajBhojwani
    PankajBhojwani committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3e31bda View commit details
    Browse the repository at this point in the history

  2. delete user actions that are identical to inbox actions

    @PankajBhojwani
    PankajBhojwani committed May 6, 2024
    Configuration menu
    Copy the full SHA
    14d83b5 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. update add action

    @PankajBhojwani
    PankajBhojwani committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5e48a45 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. remove keys from command

    @PankajBhojwani
    PankajBhojwani committed May 8, 2024
    1 Configuration menu
    Copy the full SHA
    ba375ec View commit details
    Browse the repository at this point in the history

  2. spelling

    @PankajBhojwani
    PankajBhojwani committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7d00b25 View commit details
    Browse the repository at this point in the history

  3. don't need helper anymore

    @PankajBhojwani
    PankajBhojwani committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d4d216c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. leonard comments

    @PankajBhojwani
    PankajBhojwani committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6c6dd46 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. eraseif

    @PankajBhojwani
    PankajBhojwani committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b88a8c5 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. nits n fixes

    @PankajBhojwani
    PankajBhojwani committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9703815 View commit details
    Browse the repository at this point in the history

  2. 1 more test

    @PankajBhojwani
    PankajBhojwani committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a80316d View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. x86 hash

    @PankajBhojwani
    PankajBhojwani committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    625753c View commit details
    Browse the repository at this point in the history

  2. fix loops

    @PankajBhojwani
    PankajBhojwani committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    406312f View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. conflict

    @PankajBhojwani
    PankajBhojwani committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    253dedf View commit details
    Browse the repository at this point in the history

  2. nits and changes

    @PankajBhojwani
    PankajBhojwani committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5a00d5f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge branch 'main' of https://github.com/microsoft/terminal into dev… 

    …/pabhoj/action_refactor
    @PankajBhojwani
    PankajBhojwani committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    96d8d1f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/pabhoj/action_refactor' into dev/pabhoj/command_keys

    @PankajBhojwani
    PankajBhojwani committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    327858b View commit details
    Browse the repository at this point in the history

  3. O(1), rename maps for clarity

    @PankajBhojwani
    PankajBhojwani committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    258c6eb View commit details
    Browse the repository at this point in the history

  4. ID

    @PankajBhojwani
    PankajBhojwani committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6ea25e4 View commit details
    Browse the repository at this point in the history

  5. IDTo

    @PankajBhojwani
    PankajBhojwani committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    589a1e0 View commit details
    Browse the repository at this point in the history

  6. fix test

    @PankajBhojwani
    PankajBhojwani committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    cc837b6 View commit details
    Browse the repository at this point in the history