-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a spec for "Snippets" #17329
Add a spec for "Snippets" #17329
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* [ ] The Command Palette and Suggestions UI need to be able to display both the | ||
command name and a tooltip for the comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For accessibility, remember to set the help text for the comment. Tooltips aren't really accessible since they may disappear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah but it isn't a Tooltip
, it's something more
This comment has been minimized.
This comment has been minimized.
Notes from spec review:
[1]: the json: {
"$version": "1.0.0",
"snippets":
[
{
"input": "bx\r"
"name": "Build project",
"description": "Build the project in the CWD"
}, |
b999c51 has all the feedback from the review yesterday |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking over:
- Command Palette discussion (like, adding in the discussion points)
- discussion on .wt.json being next to the settings.json (see crazy idea below)
Crazy idea: what if we hard commit to snippets only being in .wt.json files?
Here's what I mean:
- .wt.json files in the same directory as settings.json will be automatically loaded
- (Migration)
sendInput
actions in settings.json will be moved to the local .wt.json file - Users can save .wt.json files from a separate repo to their local directory (besides the settings.json) so that they always have access to them
saveSnippet
/x-save
saves the snippet to the .wt.json
Meh? I dunno, I'm not sure how valuable that is beyond just having a I'd be open to promoting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with me. Excited for Snippets! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R+ let's GOOOO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nervous excitement
This specs out a lot of plans for snippets. We've already got these in the sxnui as "tasks", but we can do so very much more.
This spec is a few years old now, but it's time for it to get promoted out of my draft branch.
References:
sendInput
to have promptable sections for further completion #12927sendInput
action #12857