Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't localize command names on the command palette #7039

Open
espresso3389 opened this issue Jul 23, 2020 · 2 comments
Open

Don't localize command names on the command palette #7039

espresso3389 opened this issue Jul 23, 2020 · 2 comments
Labels
Area-CmdPal Command Palette issues and features Area-Localization Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@espresso3389
Copy link

Environment

Windows build number: 10.0.20175.0 (Japanese)
Windows Terminal version: 1.2.2022.0

Steps to reproduce/Actual behavior

Opening command palette and type some command in English.
For example, if I want to invoke certain scroll commands, I want to search the commands with typing scro... but because Windows terminal localizes these command strings, I cannot find the commands.

cpal

Expected behavior

Please consider some way to allow us (especially CJK users) to search the commands in plain English. Typing CJK words are not so easy and if the commands are localized, it makes the command palette almost unusable.

VSCode have had similar issues before and they fixed the issue already:
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 23, 2020
@zadjii-msft
Copy link
Member

Thanks for the feedback! I didn't know that VSCode's command palette did that, so this is helpful feedback. I'm gonna stick this into 2.0 for now.

For those who want to skip to the resolution of the above thread: microsoft/vscode#4679 (comment)

@zadjii-msft zadjii-msft added Area-Localization Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Jul 23, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 23, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jul 23, 2020
@espresso3389 espresso3389 mentioned this issue Jul 23, 2020
Closed
@espresso3389
Copy link
Author

FYI, I also attach VSCode Japanese locale screenshot that shows how they deal with the command palette localization problem:

image

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 27, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 1, 2020
Open
52 tasks
This was referenced Nov 19, 2020
Closed
Closed
This was referenced Nov 29, 2020
Merged
Closed
@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@zadjii-msft zadjii-msft mentioned this issue May 26, 2021
Closed
@zadjii-msft zadjii-msft added Priority-2 A description (P2) and removed Priority-1 A description (P1) labels Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft added Priority-1 A description (P1) and removed Priority-2 A description (P2) labels Jan 4, 2022
@j4james j4james mentioned this issue Aug 6, 2022
Closed
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Dec 5, 2022
@zadjii-msft zadjii-msft mentioned this issue Jul 11, 2023
Merged
1 task
@zadjii-msft zadjii-msft mentioned this issue May 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 22, 2024
@zadjii-msft @DHowett
Add a spec for "Snippets" (#17329)
8511f3d 
This specs out a lot of plans for snippets. We've already got these in
the sxnui as "tasks", but we can do so very much more.

This spec is a few years old now, but it's time for it to get promoted
out of my draft branch.

References: 
* #1595
* #7039
* #3121
* #10436
* #12927
* #12857
* #5790
* #15845

---------

Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CmdPal Command Palette issues and features Area-Localization Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @espresso3389 @zadjii-msft