Fix spurious clear-to-end sequence in buffer dumps #17374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
Jun 5, 2024
zadjii-msft
approved these changes
Jun 5, 2024
DHowett
pushed a commit
that referenced
this pull request
Jun 7, 2024
I think I forgot to complete that section of the code... The parentheses were missing and `beg` was repeated twice. The last line in the comment above this explains what I intended it to be. Closes #17365 ## Validation Steps Performed * In a new PowerShell tab * Run ``"`e[999C`e[2D`e[42mfoo`e[m"`` * Newline until it scrolls * Run it again * Close and reopen * The green "foo" is still green ✅ (cherry picked from commit 640424e) Service-Card-Id: 92687334 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I forgot to complete that section of the code...
The parentheses were missing and
begwas repeated twice. The lastline in the comment above this explains what I intended it to be.
Closes #17365
Validation Steps Performed
"`e[999C`e[2D`e[42mfoo`e[m"