When we reload a profile, always use the same GUID for it

[zadjii-msft]

Summary of the Pull Request

This ensures that settings reload works for profiles w/o GUIDs.

After #2475, we no longer persist the auto-generated GUID for a profile. This means that when settings get reloaded, the profiles without GUIDs will get re-created, and the existing tabs with those profiles will no longer be associated with a profile. That's really bad, and can cause explosions.

This will ensure that we always generate the same GUID for a profile that didn't have one, preventing explosions.

If a person has two profiles with the same name and NO guid, then we'll generate the same GUID for both, then cull the second one when we validate that there should be no duplicate profiles.

References

#2475 caused this regression.

PR Checklist

• Don't really have an issue for this one
• I work here
• This should have tests, but much of this is changing in Add Cascading User + Default Settings #2515 anyways
• Doesn't require documentation to be updated
• @DHowett-MSFT caught this in the testing for v0.4

[carlos-zamora]

Yo dawg, I heard you like GUIDs... So I gave your GUID generator a GUID so that you can GUID while you GUID. 🤣

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 52 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.