Don't explode name-only profiles #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was thinking maybe we have the stubs have a GUID included. I like that less though I think. That would mean that DPGs would always have the GUID generated for them, even if the DPG doesn't specify a GUID. I guess that's fine though. No DPG's _aren't_ generating names now so this shouldn't change anything.
If the profile doesn't have a guid, it's a name-only profile. During validation, we'll generate a GUID for the profile, but validation occurs after this. We should ignore these types of profiles. If a dynamic profile was generated _without_ a GUID, we also don't want it serialized here. The first check in Profile::ShouldBeLayered checks that the profile hasa guid. For a dynamic profile without a GUID, that'll _never_ be true, so it would be impossible to be layered.
This reverts commit 85b8b8a.
This reverts commit f204b98.
zadjii-msft
added
Issue-Bug
|
|
||
| const auto settings0Json = VerifyParseSucceeded(settings0String); | ||
|
|
||
| CascadiaSettings settings; |
There was a problem hiding this comment.
does this test need to parse the defaults and validate them? it seems extraneous, but idk
DHowett-MSFT
approved these changes
Sep 17, 2019
Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
ghost
requested review from
miniksa
approved these changes
Sep 17, 2019
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When the user adds a name-only profile, we shouldn't re-add that to their list of profiles each time they launch the terminal.
References
Introduced in #2515 or #2603
PR Checklist