Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest MUX prerelease #3832

Merged
1 commit merged into from
Dec 4, 2019
Merged

Update to the latest MUX prerelease #3832

1 commit merged into from
Dec 4, 2019

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

Updates MUX to the latest pre-release version. This prerelease has a fix for a certain E_LAYOUTCYCLE bug in the TabView that was causing an untold number of crashes for us.

Thanks again @teaP!

PR Checklist

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 4, 2019
@ghost
Copy link

ghost commented Dec 4, 2019

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 4 hours 18 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@zadjii-msft
Copy link
Member Author

@msftbot merge this pr in 2 minutes

@ghost
Copy link

ghost commented Dec 4, 2019

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 04 Dec 2019 17:44:52 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 2f0abc2 into master Dec 4, 2019
@ghost ghost deleted the dev/migrie/f/upgrade-MUX branch December 4, 2019 18:27
DHowett-MSFT pushed a commit that referenced this pull request Dec 4, 2019
Updates MUX to the latest pre-release version. This prerelease has a fix for a certain `E_LAYOUTCYCLE` bug in the TabView that was causing an untold number of crashes for us.

Thanks again @teaP!

* [x] Closes #3303
* [x] Closes #2277
* [x] I work here
* [n/a] Tests added/passed
* [n/a] Requires documentation to be updated

(cherry picked from commit 2f0abc2)
@JustinGrote
Copy link

Is there a way to install a nightly of this? It's super annoying for me.

@zadjii-msft
Copy link
Member Author

@JustinGrote Unfortunately no, we don't really have a nightly build running currently. I believe the plan is to release a hotfix later this week with this fix however :)

@ghost
Copy link

ghost commented Dec 6, 2019

🎉Windows Terminal Preview v0.7.3382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal crashes when dragged to another monitor BUG: Crash on window resize
4 participants