Fix ResizePseudoConsole accepting negative values

[mkitzan]

Summary of the Pull Request

Change function to verify that COORD X,Y values are positive.

References

PR Checklist

• Closes Sending negative values to ResizePseudoConsole returns S_OK #3447
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Sending negative values to ResizePseudoConsole returns S_OK #3447

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Visual verification, it's a basic if statement.

Actually, wait. Just add a test and I'll approve haha.

[mkitzan]

This one's going to be a little stranger to test, because of how low level this function is. It wants a PseudoConsole pointer which, from my investigation, is inaccessible from outside winconpty.LIB (since it's the only location of the header). Would it be a problem to add winconpty.h to the Header Files folder in Host.Tests.Unit?

[DHowett-MSFT]

Let's temporarily hold off testing this one, actually. We've got #3851 tracking bringing the ConPTY tests out into the open-source project (from the Windows component where they're living) 😄

[ghost]

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download