Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResizePseudoConsole accepting negative values #3936

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Fix ResizePseudoConsole accepting negative values #3936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/winconpty/winconpty.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ HRESULT _CreatePseudoConsole(const HANDLE hToken,
// write the resize message to the pty.
HRESULT _ResizePseudoConsole(_In_ const PseudoConsole* const pPty, _In_ const COORD size)
{
if (pPty == NULL)
if (pPty == NULL || size.X < 0 || size.Y < 0)
{
return E_INVALIDARG;
}
Expand Down