When Conpty encounters an unknown string, flush immediately #4896
Conversation
…h the frame
## Summary of the Pull Request
When Conpty encounters a string we don't understand, immediately flush the frame.
## References
This PR superceeds #2665. This solution is much simpler than what was proposed in that PR.
As mentioned in #2665: "This might have some long-term consequences for #1173."
## PR Checklist
* [x] Closes #2011
* [x] Closes #4106
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated
zadjii-msft
added
Product-Conpty
| @@ -1894,6 +1887,15 @@ bool AdaptDispatch::SetCursorStyle(const DispatchTypes::CursorStyle cursorStyle) | |||
| success = _pConApi->PrivateAllowCursorBlinking(fEnableBlinking); | |||
| } | |||
|
|
|||
| // If we're a conpty, always return false, so that this cursor state will be | |||
There was a problem hiding this comment.
Why after not before?
There was a problem hiding this comment.
I moved this after to make the test work tbh. Doing this after means the conpty will still have this state in it the same as the Terminal, even if there's no way to query or use that information.
|
And finally: this will work okay, but not amazing, for things that manipulate how text is displayed — because it will happen in between the frames that render text? |
Pretty much exactly. |
There was a problem hiding this comment.
Approval, assuming it DOES work with my split sequences PR #4870
| VERIFY_IS_NOT_NULL(_pVtRenderEngine.get()); | ||
|
|
||
| auto& g = ServiceLocator::LocateGlobals(); | ||
| // auto& renderer = *g.pRender; |
DHowett-MSFT
changed the title
|
Admin merge: I removed a comment, but our CI is in deep |
When ConPTY encounters a string we don't understand, immediately flush the frame.
References
This PR supersedes #2665. This solution is much simpler than what was proposed in that PR.
As mentioned in #2665: "This might have some long-term consequences for #1173."
PR Checklist