-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copying wrapped lines by implementing better scrolling #5181
Commits on Mar 25, 2020
-
Add tracing for circling and scrolling operations. Fix improper inval…
…idation within AdjustCursorPosition routine in the subsection about scrolling down at the bottom with a set of margins enabled.
Configuration menu - View commit details
-
Copy full SHA for 4bbb63d - Browse repository at this point
Copy the full SHA 4bbb63dView commit details -
PR feedback applied. Don't bother making string if no one is listenin…
…g to ETW. Change the scroll member variable to a til::point and math that directly (and add the operators and related tests to til::point).
Configuration menu - View commit details
-
Copy full SHA for a543b1f - Browse repository at this point
Copy the full SHA a543b1fView commit details
Commits on Mar 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9ba2c69 - Browse repository at this point
Copy the full SHA 9ba2c69View commit details -
Merge remote-tracking branch 'origin/dev/miniksa/tmux_draw' into dev/…
…migrie/b/5113-with-miniksas-fix # Conflicts: # src/renderer/vt/XtermEngine.cpp # src/renderer/vt/invalidate.cpp
Configuration menu - View commit details
-
Copy full SHA for f10edc0 - Browse repository at this point
Copy the full SHA f10edc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d42f960 - Browse repository at this point
Copy the full SHA d42f960View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22bdf9b - Browse repository at this point
Copy the full SHA 22bdf9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 466e8fc - Browse repository at this point
Copy the full SHA 466e8fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 248d223 - Browse repository at this point
Copy the full SHA 248d223View commit details -
This test failure helps explain that this doesn't work
The test fails validating the second wrapped terminal line. I think the problem comes from us manually placing the cursor on the last line of the buffer. When we write the next 20 'A's, the first one gets written on the last cell of the first row, and that's bad. I'm going to see if I can't get rid of that call (the MoveCursor in PaintCursor) for this case. That seems like the cause of all this mess.
Configuration menu - View commit details
-
Copy full SHA for b94cfdb - Browse repository at this point
Copy the full SHA b94cfdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e21101b - Browse repository at this point
Copy the full SHA e21101bView commit details -
TODO: This proves that the scrolling during a frame with other text breaks this scenario. We're going to try and special-case the scrolling thing to _only_ when * the invalid area is the bottom line, and * the line wrapped So in that case, we'll be sure that the next text will cause us to move the viewport down a line appropriately I've got a crazy theory that rendering bottom-up _might_ fix this
1Configuration menu - View commit details
-
Copy full SHA for cf1145c - Browse repository at this point
Copy the full SHA cf1145cView commit details
Commits on Mar 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2665b4c - Browse repository at this point
Copy the full SHA 2665b4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a0cc20 - Browse repository at this point
Copy the full SHA 2a0cc20View commit details -
Merge remote-tracking branch 'origin/master' into dev/migrie/b/5113-w…
…ith-miniksas-fix
Configuration menu - View commit details
-
Copy full SHA for 870f052 - Browse repository at this point
Copy the full SHA 870f052View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 51f060e - Browse repository at this point
Copy the full SHA 51f060eView commit details
Commits on Mar 30, 2020
-
Merge branch 'master' into dev/migrie/b/5113-with-miniksas-fix
# Conflicts: # src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp # src/host/ut_host/ConptyOutputTests.cpp # src/renderer/vt/XtermEngine.cpp # src/renderer/vt/math.cpp
Configuration menu - View commit details
-
Copy full SHA for 8ecfcec - Browse repository at this point
Copy the full SHA 8ecfcecView commit details -
Fix the test @miniksa wrote for #5122
It was unhappy with the exact line lengths and this change
Configuration menu - View commit details
-
Copy full SHA for 436335f - Browse repository at this point
Copy the full SHA 436335fView commit details
Commits on Apr 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 022b01a - Browse repository at this point
Copy the full SHA 022b01aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac85d43 - Browse repository at this point
Copy the full SHA ac85d43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 465f8be - Browse repository at this point
Copy the full SHA 465f8beView commit details -
Configuration menu - View commit details
-
Copy full SHA for d317b8b - Browse repository at this point
Copy the full SHA d317b8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 707844d - Browse repository at this point
Copy the full SHA 707844dView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 8b19fcb - Browse repository at this point
Copy the full SHA 8b19fcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b70aacd - Browse repository at this point
Copy the full SHA b70aacdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cbcf1f - Browse repository at this point
Copy the full SHA 0cbcf1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c9a16f - Browse repository at this point
Copy the full SHA 1c9a16fView commit details
Commits on Apr 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c7e5a45 - Browse repository at this point
Copy the full SHA c7e5a45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 015844b - Browse repository at this point
Copy the full SHA 015844bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a939f7e - Browse repository at this point
Copy the full SHA a939f7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1cd2c5 - Browse repository at this point
Copy the full SHA a1cd2c5View commit details
Commits on Apr 3, 2020
-
1
Configuration menu - View commit details
-
Copy full SHA for c39871b - Browse repository at this point
Copy the full SHA c39871bView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 746a1c8 - Browse repository at this point
Copy the full SHA 746a1c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ea3960 - Browse repository at this point
Copy the full SHA 9ea3960View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 12f9c82 - Browse repository at this point
Copy the full SHA 12f9c82View commit details -
Starting on working on fixing this bug, but I can't get a minimal rep…
…ro, so I'm stashing this. re: #5161
1Configuration menu - View commit details
-
Copy full SHA for 3495cad - Browse repository at this point
Copy the full SHA 3495cadView commit details -
This scratch application repros a similar bug, so I'm treating this a…
…s the minimal repro
Configuration menu - View commit details
-
Copy full SHA for c0fb26f - Browse repository at this point
Copy the full SHA c0fb26fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 812dc86 - Browse repository at this point
Copy the full SHA 812dc86View commit details
Commits on Apr 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 87a1486 - Browse repository at this point
Copy the full SHA 87a1486View commit details -
Merge branch 'dev/migrie/b/5161-mingw-vim-fix' into dev/migrie/b/5113…
…-with-miniksas-fix
1Configuration menu - View commit details
-
Copy full SHA for 017f302 - Browse repository at this point
Copy the full SHA 017f302View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7fd127 - Browse repository at this point
Copy the full SHA c7fd127View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 55f81bc - Browse repository at this point
Copy the full SHA 55f81bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3137a3b - Browse repository at this point
Copy the full SHA 3137a3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b188629 - Browse repository at this point
Copy the full SHA b188629View commit details
Commits on Apr 8, 2020
-
1
Configuration menu - View commit details
-
Copy full SHA for 6f9bd9a - Browse repository at this point
Copy the full SHA 6f9bd9aView commit details -
Merge remote-tracking branch 'origin/master' into dev/migrie/b/5113-w…
…ith-miniksas-fix
Configuration menu - View commit details
-
Copy full SHA for 45d9f06 - Browse repository at this point
Copy the full SHA 45d9f06View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 1cc1035 - Browse repository at this point
Copy the full SHA 1cc1035View commit details -
Configuration menu - View commit details
-
Copy full SHA for c111961 - Browse repository at this point
Copy the full SHA c111961View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15a47d3 - Browse repository at this point
Copy the full SHA 15a47d3View commit details -
3
Configuration menu - View commit details
-
Copy full SHA for 5e167cd - Browse repository at this point
Copy the full SHA 5e167cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for efe4aaf - Browse repository at this point
Copy the full SHA efe4aafView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5af8c6 - Browse repository at this point
Copy the full SHA d5af8c6View commit details