Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying wrapped lines by implementing better scrolling #5181

Merged
51 commits merged into from
Apr 9, 2020

Commits on Mar 25, 2020

  1. Add tracing for circling and scrolling operations. Fix improper inval…

    …idation within AdjustCursorPosition routine in the subsection about scrolling down at the bottom with a set of margins enabled.
    miniksa committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    4bbb63d View commit details
    Browse the repository at this point in the history
  2. PR feedback applied. Don't bother making string if no one is listenin…

    …g to ETW. Change the scroll member variable to a til::point and math that directly (and add the operators and related tests to til::point).
    miniksa committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    a543b1f View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. More tracing is always good

    (cherry picked from commit d972b5e)
    zadjii-msft committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    9ba2c69 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/dev/miniksa/tmux_draw' into dev/…

    …migrie/b/5113-with-miniksas-fix
    
    # Conflicts:
    #	src/renderer/vt/XtermEngine.cpp
    #	src/renderer/vt/invalidate.cpp
    zadjii-msft committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    f10edc0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d42f960 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    22bdf9b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    466e8fc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    248d223 View commit details
    Browse the repository at this point in the history
  7. This test failure helps explain that this doesn't work

      The test fails validating the second wrapped terminal line.
    
      I think the problem comes from us manually placing the cursor on the last line
      of the buffer. When we write the next 20 'A's, the first one gets written on
      the last cell of the first row, and that's bad.
    
      I'm going to see if I can't get rid of that call (the MoveCursor in
      PaintCursor) for this case. That seems like the cause of all this mess.
    zadjii-msft committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    b94cfdb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e21101b View commit details
    Browse the repository at this point in the history
  9. Add a test for this case

        TODO: This proves that the scrolling during a frame with other text
        breaks this scenario. We're going to try and special-case the scrolling
        thing to _only_ when
        * the invalid area is the bottom line, and
        * the line wrapped
        So in that case, we'll be sure that the next text will cause us to move
        the viewport down a line appropriately
        I've got a crazy theory that rendering bottom-up _might_ fix this
    zadjii-msft committed Mar 26, 2020
    1 Configuration menu
    Copy the full SHA
    cf1145c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Configuration menu
    Copy the full SHA
    2665b4c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a0cc20 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    870f052 View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    51f060e View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Merge branch 'master' into dev/migrie/b/5113-with-miniksas-fix

    # Conflicts:
    #	src/cascadia/UnitTests_TerminalCore/ConptyRoundtripTests.cpp
    #	src/host/ut_host/ConptyOutputTests.cpp
    #	src/renderer/vt/XtermEngine.cpp
    #	src/renderer/vt/math.cpp
    zadjii-msft committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    8ecfcec View commit details
    Browse the repository at this point in the history
  2. Fix the test @miniksa wrote for #5122

      It was unhappy with the exact line lengths and this change
    zadjii-msft committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    436335f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Configuration menu
    Copy the full SHA
    022b01a View commit details
    Browse the repository at this point in the history
  2. pr nits from dustin

    zadjii-msft committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    ac85d43 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    465f8be View commit details
    Browse the repository at this point in the history
  4. pr nits from carlos

    zadjii-msft committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    d317b8b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    707844d View commit details
    Browse the repository at this point in the history
  6. 1 Configuration menu
    Copy the full SHA
    8b19fcb View commit details
    Browse the repository at this point in the history
  7. good bot

    zadjii-msft committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    b70aacd View commit details
    Browse the repository at this point in the history
  8. fix a typo

    zadjii-msft committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    0cbcf1f View commit details
    Browse the repository at this point in the history
  9. add a test for #5039

    zadjii-msft committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    1c9a16f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Configuration menu
    Copy the full SHA
    c7e5a45 View commit details
    Browse the repository at this point in the history
  2. finish the test for #5039

    zadjii-msft committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    015844b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a939f7e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a1cd2c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. 1 Configuration menu
    Copy the full SHA
    c39871b View commit details
    Browse the repository at this point in the history
  2. Frick forgot to save

    zadjii-msft committed Apr 3, 2020
    1 Configuration menu
    Copy the full SHA
    746a1c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ea3960 View commit details
    Browse the repository at this point in the history
  4. Add more comments

    zadjii-msft committed Apr 3, 2020
    1 Configuration menu
    Copy the full SHA
    12f9c82 View commit details
    Browse the repository at this point in the history
  5. Starting on working on fixing this bug, but I can't get a minimal rep…

    …ro, so I'm stashing this.
    
      re: #5161
    zadjii-msft committed Apr 3, 2020
    1 Configuration menu
    Copy the full SHA
    3495cad View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c0fb26f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    812dc86 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Configuration menu
    Copy the full SHA
    87a1486 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    017f302 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c7fd127 View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    55f81bc View commit details
    Browse the repository at this point in the history
  5. Revert scratch.exe

    zadjii-msft committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    3137a3b View commit details
    Browse the repository at this point in the history
  6. Some nits from Dustin

    zadjii-msft committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    b188629 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. 1 Configuration menu
    Copy the full SHA
    6f9bd9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45d9f06 View commit details
    Browse the repository at this point in the history
  3. some PR feedback

    zadjii-msft committed Apr 8, 2020
    1 Configuration menu
    Copy the full SHA
    1cc1035 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c111961 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    15a47d3 View commit details
    Browse the repository at this point in the history
  6. 3 Configuration menu
    Copy the full SHA
    5e167cd View commit details
    Browse the repository at this point in the history
  7. love me

    zadjii-msft committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    efe4aaf View commit details
    Browse the repository at this point in the history
  8. This makes more sense

    zadjii-msft committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    d5af8c6 View commit details
    Browse the repository at this point in the history