Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Control Flow Guard in the common build props #5453

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Enable Control Flow Guard in the common build props #5453

merged 2 commits into from
Apr 22, 2020

Conversation

DHowett-MSFT
Copy link
Contributor

Fixes #5452.

This will make security go brrrrrrr

@DHowett-MSFT
Copy link
Contributor Author

(I'm verifying right now)

@zadjii-msft
Copy link
Member

Yea what kind of negative side effects are there for this? If there's only a minor perf impact, then why the heck isn't this enabled by default in new VS projects?

@DHowett-MSFT
Copy link
Contributor Author

That's a great question!

Well, it failing right out the gate is a great indicator.

@DHowett-MSFT
Copy link
Contributor Author

Who would have thought a boolean value's supported contents were Guard and .. i don't know what the other option is. Guard and NULL i guess.

@zadjii-msft zadjii-msft added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Apr 21, 2020
@DHowett-MSFT
Copy link
Contributor Author

This will also help us pass BinSkim 😄

@miniksa miniksa added the Needs-Second It's a PR that needs another sign-off label Apr 22, 2020
@ghost ghost requested review from zadjii-msft, carlos-zamora and leonMSFT April 22, 2020 17:25
@DHowett-MSFT
Copy link
Contributor Author

@zadjii-msft not sure about side effects, but a bunch of other tools have it enabled. vs code, edge, svchost, runtimebroker, wsl.exe itself (though it's just a wrapper).. so I'm inclined to say we should just do it and deal with what may come of it

@DHowett-MSFT DHowett-MSFT merged commit 0741cfd into master Apr 22, 2020
@DHowett-MSFT DHowett-MSFT deleted the dev/duhowett/cfg branch April 22, 2020 18:30
DHowett-MSFT pushed a commit that referenced this pull request Apr 27, 2020
@DHowett
Enable Control Flow Guard in the common build props (#5453)
99a591b 
All binaries produced by our build system will have CFG enabled.

Fixes #5452
@ghost
Copy link

ghost commented Apr 28, 2020

🎉Windows Terminal Preview v0.11.1191.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could CFG be added to the main processes?
5 participants
@DHowett-MSFT @zadjii-msft @carlos-zamora @miniksa @DHowett