connection: run all pseudoconsole hosts in jobs #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also switches the manual resource management in ConhostConnection to use WIL, and modernizes the constructor to follow new code style guidelines.
DHowett-MSFT
commented
May 24, 2019
|
Okay, this is in flagrant violation of C.48 Prefer in-class initializers to member initializers in constructors for constant initializers. I got the rules backwards. 😄 |
DHowett-MSFT
commented
May 24, 2019
adiviness
approved these changes
May 24, 2019
DHowett-MSFT
force-pushed
the
dev/duhowett/job_creation_program
branch
from
5c59bc8
to
347d9b9
Compare
zadjii-msft
approved these changes
Jun 13, 2019
This was referenced Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also switches the manual resource management in
ConhostConnection to use WIL.
This change also starts conhost suspended so that we can get our lives in order before we let it start.
This seems like good practice, and it will almost certainly help with the orphaning of some conhosts after WT exits.
PR Checklist