Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding resource azuredevops_environment_resource_kubernetes #935

Merged
merged 8 commits into from Jan 15, 2024

Conversation

rdalbuquerque
Copy link
Contributor

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Added the ability to manage Kubernetes environment resources.

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Other information

This is the continuation of PR #553 , now with default azure-devops-go-api taskagent client

@rdalbuquerque rdalbuquerque changed the title K8s env adding resource azuredevops_environment_resource_kubernetes Nov 30, 2023
@xuzhang3
Copy link
Collaborator

@rdalbuquerque can you help resolve the file conflict

@rdalbuquerque
Copy link
Contributor Author

@rdalbuquerque can you help resolve the file conflict

Done!

@rdalbuquerque
Copy link
Contributor Author

Hi @xuzhang3 ,
Anything else needed on this PR?

@@ -0,0 +1,205 @@
package taskagent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename resource_kubernetes_resource.go to resource_environment_resource_kubernetes.go

@@ -0,0 +1,254 @@
//go:build (all || resource_environment_resource_kubernetes) && !exclude_resource_environment_resource_kubernetes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename resource_kubernetes_resource_test.go to resource_environment_resource_kubernetes_test.go

return fmt.Errorf("Error creating Kubernetes resource in Azure DevOps: %+v", err)
}

flattenKubernetesResource(d, project, createdResource)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create function should end with a call to the read function

Copy link
Collaborator

@xuzhang3 xuzhang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=== RUN   TestAccEnvironmentKubernetes_CreateAndUpdate
=== PAUSE TestAccEnvironmentKubernetes_CreateAndUpdate
=== CONT  TestAccEnvironmentKubernetes_CreateAndUpdate
--- PASS: TestAccEnvironmentKubernetes_CreateAndUpdate (145.46s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        165.251s

@xuzhang3 xuzhang3 merged commit 2f65ba0 into microsoft:main Jan 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants