Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] - azuredevops_git_repository - Fix default branch not set when init_type=Clean or init_type=Fork #946

Merged
merged 1 commit into from Jan 9, 2024

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Jan 3, 2024

  1. Fix branch update when branch not ready

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #944

  1. Fix init_type=Clean default branch not set when default_branchconfigured.
  2. Fix init_type=Fork default branch not set whendefault_branch configured.

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

2. Fix branch update when branch not ready
@xuzhang3
Copy link
Collaborator Author

xuzhang3 commented Jan 3, 2024

=== RUN   TestAccGitRepo_CreateAndUpdate
=== PAUSE TestAccGitRepo_CreateAndUpdate
=== RUN   TestAccGitRepo_Create_IncorrectInitialization
=== PAUSE TestAccGitRepo_Create_IncorrectInitialization
=== RUN   TestAccGitRepo_Create_Import
=== PAUSE TestAccGitRepo_Create_Import
=== RUN   TestAccGitRepo_RepoInitialization_Clean
=== PAUSE TestAccGitRepo_RepoInitialization_Clean
=== RUN   TestAccGitRepo_RepoInitialization_Uninitialized
=== PAUSE TestAccGitRepo_RepoInitialization_Uninitialized
=== RUN   TestAccGitRepo_RepoFork_BranchNotEmpty
=== PAUSE TestAccGitRepo_RepoFork_BranchNotEmpty
=== RUN   TestAccGitRepo_PrivateImport_BranchNotEmpty
=== PAUSE TestAccGitRepo_PrivateImport_BranchNotEmpty
=== CONT  TestAccGitRepo_CreateAndUpdate
=== CONT  TestAccGitRepo_RepoInitialization_Uninitialized
=== CONT  TestAccGitRepo_PrivateImport_BranchNotEmpty
=== CONT  TestAccGitRepo_RepoFork_BranchNotEmpty
=== CONT  TestAccGitRepo_Create_Import
=== CONT  TestAccGitRepo_RepoInitialization_Clean
=== CONT  TestAccGitRepo_Create_IncorrectInitialization
--- PASS: TestAccGitRepo_Create_IncorrectInitialization (4.27s)
=== NAME  TestAccGitRepo_PrivateImport_BranchNotEmpty
--- PASS: TestAccGitRepo_RepoInitialization_Uninitialized (57.28s)
--- PASS: TestAccGitRepo_RepoInitialization_Clean (57.65s)
--- PASS: TestAccGitRepo_RepoFork_BranchNotEmpty (59.53s)
--- PASS: TestAccGitRepo_PrivateImport_BranchNotEmpty (70.30s)
--- PASS: TestAccGitRepo_Create_Import (71.27s)
--- PASS: TestAccGitRepo_CreateAndUpdate (80.46s)
PASS
PASS    github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        81.349s
PASS

@xuzhang3 xuzhang3 changed the title [Bug Fix] - azuredevops_git_repository - Fix default branch not set when init_type=Clean or init_type=Fork` [Bug Fix] - azuredevops_git_repository - Fix default branch not set when init_type=Clean or init_type=Fork Jan 4, 2024
@xuzhang3 xuzhang3 merged commit 3bbbcfa into microsoft:main Jan 9, 2024
3 checks passed
@xuzhang3 xuzhang3 deleted the fix/repo_fork branch February 21, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant