Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id attribute to azuredevops_groups datasource #980

Merged
merged 4 commits into from Feb 28, 2024

Conversation

favoretti
Copy link
Contributor

@favoretti favoretti commented Feb 27, 2024

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

Same as azuredevops_users datasource - expose StorageKey descriptor value as an id attribute of groups collection.

@favoretti
Copy link
Contributor Author

@xuzhang3 mind having a look please? Thank you!

@xuzhang3
Copy link
Collaborator

=== RUN   TestAccGroupsDataSource_Read_Project
=== PAUSE TestAccGroupsDataSource_Read_Project
=== RUN   TestAccGroupsDataSource_Read_NoProject
=== PAUSE TestAccGroupsDataSource_Read_NoProject
=== CONT  TestAccGroupsDataSource_Read_Project
=== CONT  TestAccGroupsDataSource_Read_NoProject
--- PASS: TestAccGroupsDataSource_Read_NoProject (38.43s)
--- PASS: TestAccGroupsDataSource_Read_Project (64.27s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        82.132s

@xuzhang3 xuzhang3 merged commit 6f6ac2a into microsoft:main Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants