Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tf2_gnn/models/*): let __init__ pass extra kwargs to super() #41

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

mmjb
Copy link
Contributor

@mmjb mmjb commented Mar 11, 2021

This fixes #39 by passing through the new disable_tf_function_build (and potentially any future new constructor args) to the super class.

@mmjb mmjb requested a review from megstanley March 11, 2021 15:07
@pashminacameron pashminacameron self-requested a review March 12, 2021 15:42
@pashminacameron
Copy link
Contributor

pashminacameron commented Mar 12, 2021

Thanks, this works. I've tested it now. Any classes that derive from GraphTaskModel in code using tf2-gnn also need to be updated, so we may want to note this in the versioning.

@mmjb mmjb merged commit 37f5a51 into master Mar 12, 2021
@mmjb mmjb deleted the dev/mabrocks/tffunc_disable_fixes branch March 12, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when attempting to run test installation script: tf2_gnn_train RGCN PPI --max-epochs 10 data/ppi/
2 participants