Make JvmStatic opt-in and fix an erroneous usage #417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this time I've mistakenly believed that
@JvmStatic
converts a companion-object method into a bona-fide static method. That turns out to be untrue. What it does is add a second static method to the parent class that loads the companion object and calls the annotated method.R8 optimizes this away, but not everybody uses R8. Since we're moving more and more to a Kotlin-only future, and in the service of (slightly) smaller code, this PR makes
@JvmStatic
opt-in only via a compiler flag.It also fixes an erroneous usage of
@JvmStatic
, where@JvmField
is the correct and intended annotation.