Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logging and plotting in Trainers tutorial #1163

Closed
adamjstewart opened this issue Mar 8, 2023 · 0 comments · Fixed by #1189
Closed

Simplify logging and plotting in Trainers tutorial #1163

adamjstewart opened this issue Mar 8, 2023 · 0 comments · Fixed by #1189
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@adamjstewart
Copy link
Collaborator

Issue

Our Trainers tutorial has an ugly section where we use a CSVLogger, then manually parse the CSV file and make a plot of accuracy over time.

Fix

We should use tensorboard to log and plot things automatically. https://pytorch-lightning.readthedocs.io/en/stable/notebooks/course_UvA-DL/13-contrastive-learning.html has an example with a %tensorboard magic that seems to work well.

@adamjstewart adamjstewart added the documentation Improvements or additions to documentation label Mar 8, 2023
adamjstewart added a commit that referenced this issue Apr 2, 2023
* Added tensorboard logger to trainers tutorial

* add-tensorboard-for-trainers-tutorial

* Added tensorboard logger and reverted conflicts

* Add TensorboardLogger and remove CSV

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Deleted attachments

Deleted unnecessary `"attachment"{}` lines

* Changed --logdir to use `default_root_dir` variable

* Use logdir with `default_root_dir`

* add tensorboard to `release.yaml` and `workflows.yaml`

* add tensorboard to pip install

* remove unnecessary tensorboard installs

* Update trainers.ipynb

---------

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
calebrob6 pushed a commit that referenced this issue Apr 10, 2023
* Added tensorboard logger to trainers tutorial

* add-tensorboard-for-trainers-tutorial

* Added tensorboard logger and reverted conflicts

* Add TensorboardLogger and remove CSV

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Deleted attachments

Deleted unnecessary `"attachment"{}` lines

* Changed --logdir to use `default_root_dir` variable

* Use logdir with `default_root_dir`

* add tensorboard to `release.yaml` and `workflows.yaml`

* add tensorboard to pip install

* remove unnecessary tensorboard installs

* Update trainers.ipynb

---------

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
yichiac pushed a commit to yichiac/torchgeo that referenced this issue Apr 29, 2023
* Added tensorboard logger to trainers tutorial

* add-tensorboard-for-trainers-tutorial

* Added tensorboard logger and reverted conflicts

* Add TensorboardLogger and remove CSV

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Deleted attachments

Deleted unnecessary `"attachment"{}` lines

* Changed --logdir to use `default_root_dir` variable

* Use logdir with `default_root_dir`

* add tensorboard to `release.yaml` and `workflows.yaml`

* add tensorboard to pip install

* remove unnecessary tensorboard installs

* Update trainers.ipynb

---------

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
@adamjstewart adamjstewart added this to the 0.4.1 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant