Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tensorboard to trainers tutorial #1163 #1189

Merged
merged 16 commits into from
Apr 2, 2023
Merged

Add tensorboard to trainers tutorial #1163 #1189

merged 16 commits into from
Apr 2, 2023

Conversation

bugraaldal
Copy link
Contributor

@bugraaldal bugraaldal commented Mar 22, 2023 •
edited by adamjstewart
Loading

Added TensorBoardLogger and removed CSVLogger

Closes #1163

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 22, 2023
@bugraaldal
Copy link
Contributor Author

@bugraaldal please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@adamjstewart
Copy link
Collaborator

Thanks for the PR! Let's merge #1124 first so that there are fewer conflicts.

@adamjstewart adamjstewart added this to the 0.4.1 milestone Mar 22, 2023
@adamjstewart
Copy link
Collaborator

#1124 has now been merged. Can you rebase?

@bugraaldal bugraaldal force-pushed the add-tensorboard-for-trainers-tutorial branch from cebf848 to edb2dd8 Compare March 29, 2023 15:30
@adamjstewart
Copy link
Collaborator

Can you strip output and make sure the PR doesn't change the indentation of the file? Otherwise I can't easily see what changed.

@bugraaldal
Copy link
Contributor Author

@adamjstewart had issues with rebase -hence the commits- but now I believe it is clear.

adamjstewart
adamjstewart reviewed Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks beautiful on Colab! Thanks as always for your Lightning logger help.

docs/tutorials/trainers.ipynb Outdated Show resolved Hide resolved
docs/tutorials/trainers.ipynb Outdated Show resolved Hide resolved
docs/tutorials/trainers.ipynb Outdated Show resolved Hide resolved
docs/tutorials/trainers.ipynb Outdated Show resolved Hide resolved
docs/tutorials/trainers.ipynb Outdated Show resolved Hide resolved
bugraaldal and others added 6 commits March 31, 2023 00:21
@bugraaldal @adamjstewart
Update docs/tutorials/trainers.ipynb
e7bd91a 
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
@bugraaldal @adamjstewart
Update docs/tutorials/trainers.ipynb
1b9ab1f 
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
@bugraaldal @adamjstewart
Update docs/tutorials/trainers.ipynb
6232273 
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
@bugraaldal
Deleted attachments
c8ee96c 
Deleted unnecessary `"attachment"{}` lines
@bugraaldal
Changed --logdir to use default_root_dir variable
a0a48e3
@bugraaldal
Use logdir with default_root_dir
85484ab
adamjstewart
adamjstewart reviewed Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because tensorboardX is not sufficient. We have two options here:

  1. Change lightning[extra] dependency (which pulls in tensorboardX) to lightning and tensorboard (fewer deps from extra, but tensorboard has more deps)
  2. Add tensorboard to pip install in this file, .github/workflows/tutorials.yaml, and .github/workflows/release.yaml

To get this PR merged as quickly as possible, I think we should go with 2 for now, but I'll ask around and see if anyone has opinions about 1.

docs/tutorials/trainers.ipynb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the testing Continuous integration testing label Apr 1, 2023
adamjstewart
adamjstewart reviewed Apr 1, 2023
View reviewed changes
.github/workflows/release.yaml Outdated Show resolved Hide resolved
docs/tutorials/trainers.ipynb Show resolved Hide resolved
@adamjstewart adamjstewart mentioned this pull request Apr 1, 2023
Merged
@adamjstewart adamjstewart merged commit 0d8d320 into microsoft:main Apr 2, 2023
calebrob6 pushed a commit that referenced this pull request Apr 10, 2023
@bugraaldal @adamjstewart @calebrob6
Add tensorboard to trainers tutorial #1163 (#1189)
4c7e134 
* Added tensorboard logger to trainers tutorial

* add-tensorboard-for-trainers-tutorial

* Added tensorboard logger and reverted conflicts

* Add TensorboardLogger and remove CSV

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Deleted attachments

Deleted unnecessary `"attachment"{}` lines

* Changed --logdir to use `default_root_dir` variable

* Use logdir with `default_root_dir`

* add tensorboard to `release.yaml` and `workflows.yaml`

* add tensorboard to pip install

* remove unnecessary tensorboard installs

* Update trainers.ipynb

---------

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@bugraaldal @adamjstewart
Add tensorboard to trainers tutorial microsoft#1163 (microsoft#1189)
1dd5acb 
* Added tensorboard logger to trainers tutorial

* add-tensorboard-for-trainers-tutorial

* Added tensorboard logger and reverted conflicts

* Add TensorboardLogger and remove CSV

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Update docs/tutorials/trainers.ipynb

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Deleted attachments

Deleted unnecessary `"attachment"{}` lines

* Changed --logdir to use `default_root_dir` variable

* Use logdir with `default_root_dir`

* add tensorboard to `release.yaml` and `workflows.yaml`

* add tensorboard to pip install

* remove unnecessary tensorboard installs

* Update trainers.ipynb

---------

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

Simplify logging and plotting in Trainers tutorial
2 participants
@bugraaldal @adamjstewart