-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuroSAT Subclass with Longitude-Based Splits #2074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't really thought about the best way to handle multiple split definitions for a single dataset. Do we want to create a new class, or just a new parameter in the original class?
No preference. Adding a new parameter to the original class might keep things simpler and cut down on extra code though |
On a side note, it might make sense to give the users heads up that they need to manually set the stage in
|
That's something that can be documented in Lightning. I don't actually expect users to use the data module without a Trainer, which handles all of this for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs documentation: https://github.com/microsoft/torchgeo/blob/v0.5.2/docs/api/datasets.rst#L218
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Add to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: we could put Spatial before 100 in the code and docs since users aren't really giong to use 100, it's only for demos. But it's prob fine to merge as is.
No preference: So I can do that! |
Let's do it then. |
Done! |
SpatialSplitEuroSAT
subclass overriding the default splits ofEuroSAT
.Splits 60/20/20 by longitude.
Kudos to @calebrob6 for creating the spatial splits.