Add plot method to base chesapeake #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
|
This is done on purpose. Chesapeake data uses the proprietary deflate64 compression algorithm, so we want to use the same compression for the fake data. If you install |
|
Chesapeake7 and 13 have their own cmaps, which plot should use. I can fill that in though. |
|
Here's an image from the same crop of both datasets that show how the classes differ: Chesapeake 13 Chesapeake 7 |
|
I did a few other things:
|
|
Also, the fix should be in a separate PR, otherwise we can't put it in 0.2.1. |
|
The cmap fix should be in a separate PR so we can backport it to 0.2.1. |
calebrob6
approved these changes
Feb 20, 2022
Merged
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* plot method to base chesapeake * fix typo * Add plotting to Chesapeake datasets * isort, yousort, weallsort * putting back the globs * putting back the geo.py change Co-authored-by: Caleb Robinson <calebrob6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a plot method to the Chesapeake dataset baseclass to address #253. I was unable to run pytest, because the currently generated fake data cannot be unzipped:
NotImplementedError: That compression method is not supportedshould I change the archive method in the base data.py class to the
shutil.make_archive()used in other data.py files?