Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chesapeake: allow multiple datasets to share same root #420

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

adamjstewart
Copy link
Collaborator

@calebrob6 can you see if this fixes #419?

@adamjstewart adamjstewart added this to the 0.2.1 milestone Feb 20, 2022
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Feb 20, 2022
@adamjstewart
Copy link
Collaborator Author

Ugh, mypy doesn't consider properties and attributes to be compatible. Let's go with setting filename_glob in each class instead.

@calebrob6
Copy link
Member

@calebrob6 can you see if this fixes #419?

Yep, setting filename_glob definitely works when Chesapeake7, Chesapeake13, and ChesapeakeDE are all in the same directory.

@calebrob6 calebrob6 merged commit 3bff2d5 into main Feb 20, 2022
@calebrob6 calebrob6 deleted the datasets/chesapeake branch February 20, 2022 23:18
adamjstewart added a commit that referenced this pull request Mar 19, 2022
* Chesapeake: allow multiple datasets to share same root

* Set filename_glob directly
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Chesapeake: allow multiple datasets to share same root

* Set filename_glob directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chesapeake7 and Chesapeake13 can't have the same root directory
2 participants