Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indices tutorial: better normalization for true color plot #493

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Indices tutorial: better normalization for true color plot #493

merged 2 commits into from
Apr 5, 2022

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Apr 3, 2022 •
edited

This PR changes the normalization strategy for a Sentinel-2 true color image from "0.1th to 99.9th percentile" to "divide by 2000". This is in line with how our Sentinel2.plot(...) function works.

Before

before

After

after

It also fixes a couple of other bugs:

  • the normalize parameter can be any float, not just an int
  • URLs should be split by "/", not by os.sep

@adamjstewart adamjstewart added this to the 0.2.2 milestone Apr 3, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 3, 2022
@adamjstewart adamjstewart reopened this Apr 3, 2022
@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Apr 3, 2022
isaaccorley
isaaccorley approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@isaaccorley isaaccorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebrob6 calebrob6 merged commit f37c154 into main Apr 5, 2022
@calebrob6 calebrob6 deleted the tutorials/indices branch April 5, 2022 16:10
remtav pushed a commit to remtav/torchgeo that referenced this pull request May 26, 2022
@adamjstewart @remtav
Indices tutorial: better normalization for true color plot (microsoft…
fa38b2d 
…#493)

* Indices tutorial: better normalization for true color plot

* Brighten Sentinel-2 image plots
@adamjstewart adamjstewart modified the milestones: 0.2.2, 0.3.0 Jul 2, 2022
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
Merged
@adamjstewart adamjstewart mentioned this pull request Jan 20, 2023
Closed
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@adamjstewart
Indices tutorial: better normalization for true color plot (microsoft…
00aa173 
…#493)

* Indices tutorial: better normalization for true color plot

* Brighten Sentinel-2 image plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaccorley isaaccorley isaaccorley approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamjstewart @isaaccorley @calebrob6