Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landsat: add support for all Level-1 and Level-2 products #504

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Landsat: add support for all Level-1 and Level-2 products #504

merged 3 commits into from
Apr 20, 2022

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Apr 9, 2022 •
edited

Previously, our Landsat datasets only supported Level-2 Surface Reflectance products. This PR allows our datasets to also support Level-1, Level-2 Surface Temperature, Level-2 U.S. Analysis Ready Data, Quality Assurance, etc. products.

I think most users use Level-2 Surface Reflectance data, so our current bands default is best. We don't currently test to ensure that the bands passed to a dataset are valid, but we could if someone wants to dig through all the docs and determine all possible files for each mission.

Also fixes a couple other issues:

  • Found more detailed citation info for Level-2 products
  • Fix bug where no files would be found when the band we chose to put into the filename_glob was not included in bands

Fixes #492

@adamjstewart adamjstewart added this to the 0.3.0 milestone Apr 9, 2022
@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels Apr 9, 2022
@adamjstewart adamjstewart mentioned this pull request Apr 9, 2022
Closed
@adamjstewart adamjstewart merged commit 8b3e581 into main Apr 20, 2022
@adamjstewart adamjstewart deleted the datasets/landsat branch April 20, 2022 16:06
remtav pushed a commit to remtav/torchgeo that referenced this pull request May 26, 2022
@adamjstewart @remtav
Landsat: add support for all Level-1 and Level-2 products (microsoft#504
ab66ed9 
)

* Landsat: allow use of non-SR bands

* Fix citation

* The more citation the better
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
Merged
@adamjstewart adamjstewart mentioned this pull request Feb 22, 2023
Merged
2 tasks
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@adamjstewart
Landsat: add support for all Level-1 and Level-2 products (microsoft#504
f36c2a2 
)

* Landsat: allow use of non-SR bands

* Fix citation

* The more citation the better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebrob6 calebrob6 calebrob6 approved these changes

@isaaccorley isaaccorley isaaccorley approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Landsat datasets don't support Level-1 products
3 participants
@adamjstewart @calebrob6 @isaaccorley