Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matmul kernel test for CPU backend #67

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

nhat-nguyen
Copy link
Collaborator

Add the latest matmul triton tutorial as a test for the CPU backend. This exposed a bug in the TritonToLinalg pass where we need to initialize the init tensor with all zeroes first since allocated buffers aren't guaranteed to be zero-initialized.

Copy link
Collaborator

@manbearian manbearian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only feedback is around looking for a way to avoid replicating the existing tutorial code.

python/examples/test_matmul.py Show resolved Hide resolved
@manbearian
Copy link
Collaborator

manbearian commented Nov 29, 2023 via email

@nhat-nguyen nhat-nguyen merged commit 5e503a0 into main Dec 1, 2023
2 checks passed
@nhat-nguyen nhat-nguyen deleted the nhat/matmul_init branch December 1, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants